[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-20 Thread Hubert Tong via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: hubert-reinterpretcast wrote: > LLVM patch releases cannot break API or ABI compatibility Thanks @nikic for the explanation. I thought you meant ABI compatibility in the "user program" sense. https://github.com/llvm/llvm-project/pul

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-20 Thread Nikita Popov via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: nikic wrote: @hubert-reinterpretcast This patch modifies structure layout in exported headers, changing the libclang-cpp ABI. LLVM patch releases cannot break API or ABI compatibility, see the last point in https://llvm.org/docs/How

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-19 Thread Hubert Tong via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: hubert-reinterpretcast wrote: > This is an ABI-breaking fix, so it cannot be backported in this form. @nikic, can you explain this statement? Is this something that can be documented in the release notes: https://github.com/llvm/llv

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-16 Thread Nikita Popov via cfe-commits
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?= Message-ID: In-Reply-To: nikic wrote: This is an ABI-breaking fix, so it cannot be backported in this form. https://github.com/llvm/llvm-project/pull/118288 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-16 Thread via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: lbonn wrote: Given that the original report is a regression that prevents using the current version of mp-units, I would advocate for a backport. As I understand, the procedure is to send the cherry-pick command that will be picked

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-10 Thread via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/118288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-10 Thread Alejandro Álvarez Ayllón via cfe-commits
alejandro-alvarez-sonarsource wrote: Thanks! Can you do the merge? I do not have the rights. Also, would it make sense to backport to 19? https://github.com/llvm/llvm-project/pull/118288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-09 Thread Erich Keane via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: erichkeane wrote: > @erichkeane I'm not seeing any significant compile-time impact: > https://llvm-compile-time-tracker.com/compare.php?from=e0ea9fd6dc36f585e364d4e569095ebe063e2573&to=7fb8c423fddd1a81287b54f48da4de1c81566fc1&stat=ins

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-09 Thread Nikita Popov via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: nikic wrote: @erichkeane I'm not seeing any significant compile-time impact: https://llvm-compile-time-tracker.com/compare.php?from=e0ea9fd6dc36f585e364d4e569095ebe063e2573&to=7fb8c423fddd1a81287b54f48da4de1c81566fc1&stat=instructions

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-09 Thread Erich Keane via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: https://github.com/erichkeane approved this pull request. This seems like a reasonable solution for this, though I'd very much like to see the compile-time perf results for this before committing. @nikic , is this something we can d

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0611fdd32046c41647a7719252166033f7bce2f2 998ea6184faa12f6137d5b20f0a5f9279b14623a --e

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-02 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/118288 From 998ea6184faa12f6137d5b20f0a5f9279b14623a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Mon, 2 Dec 2024 10:48:52 +0100 Subject: [PATCH 1/2] [c

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alejandro Álvarez Ayllón (alejandro-alvarez-sonarsource) Changes ...in `ASTContext::getAutoTypeInternal` Given ```cpp template < typename > concept C1 = true; template < typename , auto > concept C2 = true; template < C1 auto V, C2< V >

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-02 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource created https://github.com/llvm/llvm-project/pull/118288 ...in `ASTContext::getAutoTypeInternal` Given ```cpp template < typename > concept C1 = true; template < typename , auto > concept C2 = true; template < C1 auto V, C2< V > auto> struct S

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-02 Thread via cfe-commits
graphite-app[bot] wrote: ## Your org has enabled the Graphite merge queue for merging into main Add the label “FP Bundles” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the