[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: @shafik Could you let me know if there are any more changes that are needed here? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From 864bd0ef7b6bbb0bc1502ef5884ae3c261d3b156 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug w

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: @cor3ntin Could you help me in closing this? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From 1923c212515033dbb92f09c6d11cd2b679261459 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug w

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

xgupta wrote: > @cor3ntin Could you describe the format of the `release note` briefly so I > can `amend` my `commit` accordingly? Like this - https://github.com/llvm/llvm-project/pull/74553/files#diff-ec770381d76c859f5f572db789175fe44410a72608f58ad5dbb14335ba56eb97 You also need to clang-forma

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: @cor3ntin Could you describe the format of the `release note` briefly so I can `amend` my `commit` accordingly? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 edited https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

cor3ntin wrote: LGTM too. Please add a release note though https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

Rajveer100 wrote: Why are `clang-format` changes showing up for changes not committed by me? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4f5d463505b3e313cd3943132e7b2784a65c39d9 efea75d1ae4a1da80b16b3e743a15a82b5f8d971 --

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

@@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify +// RUN: %clang_cc1 -fsyntax-only -std=c++23 %s -verify + +// expected-no-diagnostics + +struct A {}; +using CA = const A; + +struct S1 : CA { Rajveer100 wrote: In the `godbolt` links, the c

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/70594 >From efea75d1ae4a1da80b16b3e743a15a82b5f8d971 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 29 Oct 2023 18:37:17 +0530 Subject: [PATCH] [clang] Fix a crash in debug mode Resolves Issue #35603 This bug w

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

@@ -6431,7 +6431,7 @@ static bool HandleConstructorCall(const Expr *E, const LValue &This, // Non-virtual base classes are initialized in the order in the class // definition. We have already checked for virtual base classes. assert(!BaseIt->isVirtual() && "v

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

@@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify shafik wrote: Normally if we add a new test just for a specific bug report we name it something like `GH35603.cpp` so we can readily identify the test is linked to github issue 35603. If w

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

@@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify +// RUN: %clang_cc1 -fsyntax-only -std=c++23 %s -verify + +// expected-no-diagnostics + +struct A {}; +using CA = const A; + +struct S1 : CA { shafik wrote: These examples: https://godbolt.o

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Rajveer Singh Bharadwaj (Rajveer100) Changes Resolves Issue #35603 This change makes the `assertion` less strict in `debug` builds by stripping qualifiers from the base class and ignoring them. I hope `weakened` assertions don't affect o

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/70594 Resolves Issue #35603 This change makes the `assertion` less strict in `debug` builds by stripping qualifiers from the base class and ignoring them. I hope `weakened` assertions don't affect other cases wher