[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

github-actions[bot] wrote: @matts1 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/ChuanqiXu9 approved this pull request. https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

@@ -0,0 +1,31 @@ +// RUN: split-file %s %t + +// There are two requirements here to result in the owner of a macro being null. atetubou wrote: Which macro has null owner module in this test? https://github.com/llvm/llvm-project/pull/130712 _

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/matts1 updated https://github.com/llvm/llvm-project/pull/130712 >From 2c0dc1e7ee6a7ec499f4fcb88c79dc1aff8ce2ca Mon Sep 17 00:00:00 2001 From: Matt Stark Date: Mon, 10 Mar 2025 13:07:29 +1100 Subject: [PATCH 1/2] [clang] Fix a segfault when M is a nullptr --- clang/docs/Rele

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

@@ -318,6 +318,7 @@ Bug Fixes to C++ Support - Fixed an assertion failure affecting code that uses C++23 "deducing this". (#GH130272) - Clang now properly instantiates destructors for initialized members within non-delegating constructors. (#GH93251) - Correctly diagnoses if

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/matts1 updated https://github.com/llvm/llvm-project/pull/130712 >From 2c0dc1e7ee6a7ec499f4fcb88c79dc1aff8ce2ca Mon Sep 17 00:00:00 2001 From: Matt Stark Date: Mon, 10 Mar 2025 13:07:29 +1100 Subject: [PATCH] [clang] Fix a segfault when M is a nullptr --- clang/docs/ReleaseN

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/cor3ntin commented: This change needs a release note. Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, and referencing any Github issue this change fixes. Thanks! https://github.com/llvm/llvm-project/pull/130712

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

@@ -0,0 +1,35 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// There are two requirements here to result in the owner of a macro being null. +// 1) There must be a configuration mismatch between a header and a file it depends on +// 2) -fmodules-local-s

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/matts1 updated https://github.com/llvm/llvm-project/pull/130712 >From cf5684b715efd0ac5348c1d17e86ad5afe87b193 Mon Sep 17 00:00:00 2001 From: Matt Stark Date: Mon, 10 Mar 2025 13:07:29 +1100 Subject: [PATCH] [clang] Fix a segfault when M is a nullptr --- clang/include/clang

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

matts1 wrote: I have a repro, but it may be addressing the symptoms rather than the root cause. AFAICT, a macro should *always* have an associated module (not sure how the implementation works without modules though). However, the root cause of the issue appears to be that in the example I p

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/ChuanqiXu9 approved this pull request. https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/shafik commented: This needs a release note and it would be helpful to know how you found this and a test w/ a minimal reproducer. Are there any bugs reports for this? https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits

[clang] [clang] Fix a segfault when M is a nullptr (PR #130712)

https://github.com/ChuanqiXu9 commented: The patch itself seems not bad. But we prefer to ask for a test for such changes. https://github.com/llvm/llvm-project/pull/130712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/