https://github.com/kyulee-com closed
https://github.com/llvm/llvm-project/pull/69489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dwblaikie approved this pull request.
Looks good.
I wonder how this happened in the first place - that the author of the
diagnostic was already adding the 3rd parameter into the arguments but there
was no `%2` in the diagnostic text/template...
It'd be great if we had some
https://github.com/NuriAmari updated
https://github.com/llvm/llvm-project/pull/69489
>From 3fa795fae47d00ece00e9414a268610d3c4a6bf3 Mon Sep 17 00:00:00 2001
From: Nuri Amari
Date: Fri, 22 Sep 2023 12:03:23 -0700
Subject: [PATCH 1/2] Expand invalid PCM diagnostic
Summary:
When a PCM file is lo
@@ -62,7 +62,7 @@ def err_ast_file_out_of_date : Error<
"%select{PCH|module|AST}0 file '%1' is out of date and "
"needs to be rebuilt%select{|: %3}2">, DefaultFatal;
def err_ast_file_invalid : Error<
- "file '%1' is not a valid precompiled %select{PCH|module|AST}0 file">,
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nuri Amari (NuriAmari)
Changes
Summary:
When a PCM file is loaded, it can go wrong in various ways. The current
diagnostic only produces the name of the malformed PCM, not why it is
malformed. Expand the diagnostic to display what went w
https://github.com/NuriAmari created
https://github.com/llvm/llvm-project/pull/69489
Summary:
When a PCM file is loaded, it can go wrong in various ways. The current
diagnostic only produces the name of the malformed PCM, not why it is
malformed. Expand the diagnostic to display what went wro
