https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/100785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
FPar wrote:
@efriedma-quic Thank you for being patient. I do not have write permissions,
can you please merge this for me?
https://github.com/llvm/llvm-project/pull/100785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/efriedma-quic approved this pull request.
https://github.com/llvm/llvm-project/pull/100785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785
>From 13f60e1835c2a5876fa873fc5b4087f942a90316 Mon Sep 17 00:00:00 2001
From: Fabian Parzefall
Date: Fri, 26 Jul 2024 10:46:22 -0700
Subject: [PATCH 1/2] [clang] Check inline defs when emitting speculative
vtable
https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785
>From 13f60e1835c2a5876fa873fc5b4087f942a90316 Mon Sep 17 00:00:00 2001
From: Fabian Parzefall
Date: Fri, 26 Jul 2024 10:46:22 -0700
Subject: [PATCH] [clang] Check inline defs when emitting speculative vtable
Clang
https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785
>From 0f43c9933022ec825bfe3ede5c1622900eb86691 Mon Sep 17 00:00:00 2001
From: Fabian Parzefall
Date: Fri, 26 Jul 2024 10:46:22 -0700
Subject: [PATCH] [clang] Check inline defs when emitting speculative vtable
Clang
FPar wrote:
Yes, that sums it up well. I will see to adding a patch clarifying this in the
source. Thank you!
https://github.com/llvm/llvm-project/pull/100785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/efriedma-quic approved this pull request.
LGTM... but please consider submitting a patch to expand the explanation in
ItaniumCXXABI::canSpeculativelyEmitVTableAsBaseClass.
If I'm following correctly, the function in question is, in fact, odr-used in
the translation unit in q
https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785
>From 0f43c9933022ec825bfe3ede5c1622900eb86691 Mon Sep 17 00:00:00 2001
From: Fabian Parzefall
Date: Fri, 26 Jul 2024 10:46:22 -0700
Subject: [PATCH] [clang] Check inline defs when emitting speculative vtable
Clang
FPar wrote:
@efriedma-quic Have you been able to take another look?
https://github.com/llvm/llvm-project/pull/100785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
FPar wrote:
Yes, certainly!
The example below demonstrates a case where the `available_externally` vtable
mismatches the actual definition, and holds a reference to a symbol that does
not exist in the final program. You can see the mismatch by compiling with `-O1
-flto=thin`. The generated LL
efriedma-quic wrote:
Can you give a self-contained example that shows why this is a problem? (I
mean, I can imagine there could be some interaction that causes issues, but I'm
not sure what that interaction is, in this context.)
https://github.com/llvm/llvm-project/pull/100785
___
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Fabian Parzefall (FPar)
Changes
Clang should only emit an available_externally vtable when there are no unused
virtual inline functions. Currently, if such such a function is declared
without inline inside the class, but is define
https://github.com/FPar created https://github.com/llvm/llvm-project/pull/100785
Clang should only emit an available_externally vtable when there are no unused
virtual inline functions. Currently, if such such a function is declared
without inline inside the class, but is defined inline outside
14 matches
Mail list logo
