https://github.com/AaronBallman approved this pull request.
LGTM aside from a change to the documentation. Thank you!
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 01/13] __nullptr -> KEYALL, added relevant test
---
clang/include
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -514,9 +514,7 @@ available in all language modes.
__nullptr
-
-``__nullptr`` is an alternate spelling for ``nullptr``, but is also available
in
-C++ modes prior to C++11. Note that it's currently not availbale in C despite
-C23 having support for ``nullptr``.
+``__
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 01/12] __nullptr -> KEYALL, added relevant test
---
clang/include
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 01/11] __nullptr -> KEYALL, added relevant test
---
clang/include
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/9] __nullptr -> KEYALL, added relevant test
---
clang/include/c
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 01/10] __nullptr -> KEYALL, added relevant test
---
clang/include
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/8] __nullptr -> KEYALL, added relevant test
---
clang/include/c
AidanGoldfarb wrote:
Updating LanguageExtensions.rst before merge (and final reviews).
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/8] __nullptr -> KEYALL, added relevant test
---
clang/include/c
@@ -113,5 +113,3 @@ void foo(void *);
void bar() { foo(__nullptr); }
static_assert(nullptr == __nullptr);
static_assert(_Generic(typeof(__nullptr), nullptr_t: true, default: false));
-_Static_assert(__nullptr == 0); // Test that its value matches that of NULL
e
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/7] __nullptr -> KEYALL, added relevant test
---
clang/include/c
@@ -108,3 +108,8 @@ void test_f1() {
int ir = (f1)(nullptr);
}
+// __nullptr keyword in C
+void foo(void *);
+void bar() { foo(__nullptr); }
+static_assert(nullptr == __nullptr);
+static_assert(_Generic(typeof(__nullptr), nullptr_t: true, default: false));
e
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/6] __nullptr -> KEYALL, added relevant test
---
clang/include/c
@@ -325,6 +325,7 @@ C Language Changes
--
- Extend clang's to define ``LONG_LONG_*`` macros for Android's
bionic.
+- Added support for the ``__nullptr`` keyword.
erichkeane wrote:
```suggestion
- Exposed the the ``__nullptr`` keyword as
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/5] __nullptr -> KEYALL, added relevant test
---
clang/include/c
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/3] __nullptr -> KEYALL, added relevant test
---
clang/include/c
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/4] __nullptr -> KEYALL, added relevant test
---
clang/include/c
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,3 +108,8 @@ void test_f1() {
int ir = (f1)(nullptr);
}
+// __nullptr keyword in C
+void foo(void *);
+void bar() { foo(__nullptr); }
+static_assert(nullptr == __nullptr);
+static_assert(_Generic(typeof(__nullptr), nullptr_t: true, default: false));
A
https://github.com/AaronBallman commented:
Please be sure to also update `clang/docs/ReleaseNotes.rst` so users know about
the new functionality. Also, not signing you up for this work, but we really
should document all of these keywords in `clang/docs/LanguageExtensions.rst`.
Maybe it's worth
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/123119
>From 51372333df218cfb4fa8dcc0cebee03c0e3ebc5f Mon Sep 17 00:00:00 2001
From: Aidan
Date: Wed, 15 Jan 2025 15:24:12 -0500
Subject: [PATCH 1/2] __nullptr -> KEYALL, added relevant test
---
clang/include/c
https://github.com/Sirraide commented:
Looking good overall, but this still needs a release note.
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -108,3 +108,6 @@ void test_f1() {
int ir = (f1)(nullptr);
}
+// __nullptr keyword in C
+void foo(void *);
+void bar() { foo(__nullptr); }
Sirraide wrote:
nit: missing newline at the end of the file
https://github.com/llvm/llvm-project/pull/123119
__
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,3 +108,6 @@ void test_f1() {
int ir = (f1)(nullptr);
}
+// __nullptr keyword in C
Sirraide wrote:
Maybe also add these:
```c
static_assert(nullptr == __nullptr);
static_assert(_Generic(typeof(__nullptr), nullptr_t: true, default: false));
```
Just s
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aidan Goldfarb (AidanGoldfarb)
Changes
This PR resolves #121503.
I was not sure whether I added my test in the correct place, and if so, if that
deprecates
[nullptr-98.cpp](https://github.com/llvm/llvm-project/blob/main/clang/test/SemaC
https://github.com/AidanGoldfarb ready_for_review
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AidanGoldfarb edited
https://github.com/llvm/llvm-project/pull/123119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
31 matches
Mail list logo
