[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
MaskRay wrote: There is a typo in the subject. Absoultify => Absolutify. That said, sth like "canonicalize absolute paths " seem more appropriate wrt the changed semantics. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From a4997209062fe1e2b23dcbe88ed2cdcdf8c9a0db Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
@@ -47,4 +47,4 @@ // RUN: %clang_cc1 -D REINCLUDE -I %t -ivfsoverlay %t.yaml -Eonly %s -MTfoo -dependency-file %t.dep // RUN: cat %t.dep | FileCheck --check-prefix=CHECK-DEP %s -// CHECK-DEP-NOT: Inputs +// CHECK-DEP: Inputs MaskRay wrote: `Inputs{{..?}}exte

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
@@ -312,11 +315,22 @@ void DependencyFileGenerator::finishedMainFile(DiagnosticsEngine &Diags) { /// https://msdn.microsoft.com/en-us/library/dd9y37ha.aspx for NMake info, /// https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx /// for Windows file

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 057dfa5d362257632a88b65e537df0b4fe806fe8 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 79d2ed6ece54a9c1c7acd785156b5ffe10eb2ec7 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From ac31b0da02dac47e4099788d75f60970919c854f Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 2aaa66fe42e10b968cfe259bfca721645d97b49c Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 9677fc64da8fa1bea56e6cee337f9fa90f6b7101 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 30c066f70dda6995e38f8f5288faf37e24520ec0 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 00d35dcad3534cedc1373c957704366f8dc30225 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From a6837f7d31a54cc7e6e5bd6f18e19beb64feaf49 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 918316d3ee86c1655600738d201e42b30d8bedff Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-30 Thread Fangrui Song via cfe-commits
@@ -312,11 +314,18 @@ void DependencyFileGenerator::finishedMainFile(DiagnosticsEngine &Diags) { /// https://msdn.microsoft.com/en-us/library/dd9y37ha.aspx for NMake info, /// https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx /// for Windows file

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-30 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-30 Thread Fangrui Song via cfe-commits
@@ -312,11 +314,18 @@ void DependencyFileGenerator::finishedMainFile(DiagnosticsEngine &Diags) { /// https://msdn.microsoft.com/en-us/library/dd9y37ha.aspx for NMake info, /// https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx /// for Windows file

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-28 Thread via cfe-commits
xtexChooser wrote: cc @MaskRay https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-30 Thread via cfe-commits
xtexChooser wrote: cc @jansvoboda11 https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-30 Thread via cfe-commits
xtexChooser wrote: Ping https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 3a9de0b6c2b3f8283080cd1f051fca5577116e59 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From eb468c6e56ca906925d5ebd1a13cc510d86754d5 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: xtex (xtexChooser) Changes This fixes #117438. If paths in dependency file are not absoulte, make (or ninja) will canonicalize them. While their canonicalization does not involves symbolic links expansion (for IO performance concerns), l

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-11-23 Thread via cfe-commits
https://github.com/xtexChooser created https://github.com/llvm/llvm-project/pull/117458 This fixes #117438. If paths in dependency file are not absoulte, make (or ninja) will canonicalize them. While their canonicalization does not involves symbolic links expansion (for IO performance concern