[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/5076 Here is the relevan

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/ssahasra closed https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/jayfoad approved this pull request. https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

@@ -78,7 +78,7 @@ static void BuildParentMap(MapTy& M, Stmt* S, // The right thing to do is to give the OpaqueValueExpr its syntactic // parent, then not reassign that when traversing the semantic expressions. OpaqueValueExpr *OVE = cast(S); -if (OVMode == OV_Tr

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

@@ -34,13 +34,13 @@ static void BuildParentMap(MapTy& M, Stmt* S, case Stmt::PseudoObjectExprClass: { PseudoObjectExpr *POE = cast(S); -if (OVMode == OV_Opaque && M[POE->getSyntacticForm()]) +if (OVMode == OV_Opaque && M.contains(POE->getSyntacticForm())) ---

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/ssahasra updated https://github.com/llvm/llvm-project/pull/121736 >From 2cae10eb0b1e94729c26299af018216e729607de Mon Sep 17 00:00:00 2001 From: Sameer Sahasrabuddhe Date: Thu, 2 Jan 2025 14:30:07 +0530 Subject: [PATCH 1/2] [clang] explicitly check if ParentMap contains key T

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/ssahasra updated https://github.com/llvm/llvm-project/pull/121736 >From 2cae10eb0b1e94729c26299af018216e729607de Mon Sep 17 00:00:00 2001 From: Sameer Sahasrabuddhe Date: Thu, 2 Jan 2025 14:30:07 +0530 Subject: [PATCH 1/2] [clang] explicitly check if ParentMap contains key T

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

@@ -78,7 +78,7 @@ static void BuildParentMap(MapTy& M, Stmt* S, // The right thing to do is to give the OpaqueValueExpr its syntactic // parent, then not reassign that when traversing the semantic expressions. OpaqueValueExpr *OVE = cast(S); -if (OVMode == OV_Tr

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

@@ -34,13 +34,13 @@ static void BuildParentMap(MapTy& M, Stmt* S, case Stmt::PseudoObjectExprClass: { PseudoObjectExpr *POE = cast(S); -if (OVMode == OV_Opaque && M[POE->getSyntacticForm()]) +if (OVMode == OV_Opaque && M.contains(POE->getSyntacticForm())) ---

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/jayfoad commented: No objections, just a couple of ideas for improvements. I have no idea if `ParentMap` lookups are on any kind of hot path. https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/jayfoad edited https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

https://github.com/ssahasra edited https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits