[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

llvmbot wrote: Failed to cherry-pick: https://github.com/llvm/llvm-project/actions/runs/10079206235 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare) https://github.com/llvm/llv

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ldionne wrote: @ian-twilightcoder You can create an issue if you want, but you can also say /cherry-pick directly from the PR as long as you add the release milestone to it. That being said, the cherry-pick failed so you will need to create a PR manually. https://github.com/llvm/llvm-projec

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

llvmbot wrote: Failed to cherry-pick: COMMIT-SHA` https://github.com/llvm/llvm-project/actions/runs/10065620100 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare) https://github.c

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

llvmbot wrote: /pull-request llvm/llvm-project#100191 https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ian-twilightcoder wrote: > @ian-twilightcoder Cherry-picking is easy. Once this is merged, follow the > guidelines here to get it cherry-picked: > https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches > > Basically you only need to add a comment to this PR like `/cherry-p

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ian-twilightcoder wrote: /cherry-pick 92a9d4831d5e40c286247c30fcd794563adbef6e https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/AaronBallman approved this pull request. > The Driver/linker-wrapper-passes.c test failure doesn't look related, that > test doesn't use stddef.h or anything else. I keep trying to rebase to make > it go away but it's stubborn. I looked at the failures as well and I think th

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ian-twilightcoder wrote: The Driver/linker-wrapper-passes.c test failure doesn't look related, that test doesn't use stddef.h or anything else. I keep trying to rebase to make it go away but it's stubborn. https://github.com/llvm/llvm-project/pull/99727

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

llvmbot wrote: Failed to cherry-pick: COMMIT-SHA` https://github.com/llvm/llvm-project/actions/runs/10063850061 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare) https://github.c

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ldionne wrote: @ian-twilightcoder Cherry-picking is easy. Once this is merged, follow the guidelines here to get it cherry-picked: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches Basically you only need to add a comment to this PR like `/cherry-pick COMMIT-SHA` and

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ian-twilightcoder wrote: > > @AaronBallman Should this be added to the 19.x milestone and cherry-picked? > > I think it should be Nuts, should've merged it yesterday. https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-co

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

AaronBallman wrote: > @AaronBallman Should this be added to the 19.x milestone and cherry-picked? I think it should be https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ldionne wrote: @AaronBallman Should this be added to the 19.x milestone and cherry-picked? https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From bb9a412c4a744d71d7630978ee51022804d70ee5 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 5e50bd5c4a9ed2f9fd0eea1431a2150886c4a00f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From f494a4cece55c8ca97cfc6622e1518a9ffb8cbef Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,24 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) || __has_feature(modules) +/* + * __stddef_null.h is special when building without modules: if __need_NULL is + * set, then it will unconditionally redefine NULL. To avoid stepping

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From af616b8a6406636f9ac91b1a5b92194315012ba1 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 29915cdec1c596767f63eb164cf96180dfcd3bc7 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,25 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) && !__building_module(_Builtin_stddef) ian-twilightcoder wrote: clang/test/Modules/stddef.cpp shows how even if we've already had a full include of the entirety

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -20,19 +20,18 @@ * modules. */ #if defined(__MVS__) && __has_include_next() -#include <__stdarg_header_macro.h> #undef __need___va_list #undef __need_va_list #undef __need_va_arg #undef __need___va_copy #undef __need_va_copy +#include <__stdarg_header_macro.h> ---

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 58361b689ba66c5cc7142e22843d5a08471ad3e0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/AaronBallman commented: With additional test coverage, the changes LGTM but I'd appreciate it if @zygoloid or @ChuanqiXu9 could validate the modules logic. https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

AaronBallman wrote: > > These changes should come with a release note so users know about the fix. > > Does it need a release note? It was introduced in 19 with #90676, and this > will fix it in 19 too. Ah nope, no need for a release note then! https://github.com/llvm/llvm-project/pull/99727

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -20,19 +20,18 @@ * modules. */ #if defined(__MVS__) && __has_include_next() -#include <__stdarg_header_macro.h> #undef __need___va_list #undef __need_va_list #undef __need_va_arg #undef __need___va_copy #undef __need_va_copy +#include <__stdarg_header_macro.h> ---

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ian-twilightcoder wrote: > These changes should come with a release note so users know about the fix. Does it need a release note? It was introduced in 19 with https://github.com/llvm/llvm-project/pull/90676, and this will fix it in 19 too. https://github.com/llvm/llvm-project/pull/99727 _

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/AaronBallman commented: These changes should come with a release note so users know about the fix. https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -20,19 +20,18 @@ * modules. */ #if defined(__MVS__) && __has_include_next() -#include <__stdarg_header_macro.h> #undef __need___va_list #undef __need_va_list #undef __need_va_arg #undef __need___va_copy #undef __need_va_copy +#include <__stdarg_header_macro.h> ---

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From e956b0deb6dff3513f725ad601c2003123841832 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 4b8c087dc0318d1802f7635e1d33942cbf833109 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 294a7cce4f72324ac9042ef0c3725d3e088b16b5 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,25 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) && !__building_module(_Builtin_stddef) ian-twilightcoder wrote: We do still need everything when we're building with modules for the reasons outlined in the comm

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -49,7 +48,25 @@ #define __need_rsize_t #endif #define __need_wchar_t +#if !defined(__STDDEF_H) && !__building_module(_Builtin_stddef) zygoloid wrote: I'm not sure that the second condition here makes any difference: I'd think the only way we could get here

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Ian Anderson (ian-twilightcoder) Changes stddef.h always includes __stddef_null.h. This is fine in modules because it's not possible to re-include the pcm, and it's necessary to export the _Builtin_stddef.null submodule. However, without

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Ian Anderson (ian-twilightcoder) Changes stddef.h always includes __stddef_null.h. This is fine in modules because it's not possible to re-include the pcm, and it's necessary to export the _Builtin_stddef.null submodule. However, wi

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/99727 stddef.h always includes __stddef_null.h. This is fine in modules because it's not possible to re-include the pcm, and it's necessary to export the _Builtin_stddef.null submodule. However, without modu