[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/114394 >From eb74d413d2f5e5dcc520282a5c59893d5bf5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Thu, 31 Oct 2024 20:06:55 +0800 Subject: [PATCH] [clang][driver] Improve warning message for AVR when no '-mmcu' opt

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: Maybe add " when no -mmcu option is used" to the commit title but otherwise LGTM. https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes Fixes https://github.com/llvm/llvm-project/issues/96743 --- Full diff: https://github.com/llvm/llvm-project/pull/114394.diff 2 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticDriverKinds.td (

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/114394 Fixes https://github.com/llvm/llvm-project/issues/96743 >From 78f1d4654674f671834e2ebe44877d632da8ee8b Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Thu, 31 Oct 2024 20:06:55 +0800 Subject: [PATCH] [clang][dri