https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/69975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/69975
>From 5dd9d64726dba95f71dfb276dd1be4d386313a99 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Tue, 10 Oct 2023 14:16:13 -0700
Subject: [PATCH 1/6] [clang][modules] Make `DIAGNOSTIC_OPTIONS` skippable
---
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/69975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1212,52 +1212,54 @@ void ASTWriter::writeUnhashedControlBlock(Preprocessor
&PP,
Record.clear();
}
+ const auto &HSOpts = PP.getHeaderSearchInfo().getHeaderSearchOpts();
+
// Diagnostic options.
const auto &Diags = Context.getDiagnostics();
const Diagnostic
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/69975
>From 0270c76e779457486ee89f100db2b7151832c290 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Tue, 10 Oct 2023 14:16:13 -0700
Subject: [PATCH 1/5] [clang][modules] Make `DIAGNOSTIC_OPTIONS` skippable
---
@@ -219,6 +219,12 @@ class HeaderSearchOptions {
unsigned ModulesValidateDiagnosticOptions : 1;
+ /// Whether to entirely skip writing diagnostic options.
+ unsigned ModulesSkipDiagnosticOptions : 1;
+
+ /// Whether to entirely skip writing header search paths.
-
jansvoboda11 wrote:
> Besides deps scanning, have you tried to enable these option to compile with
> clang modules? I mean, if it is safe to enable such options at compilation
> times, it looks a valid optimization for C++20 modules too.
I did not. I suspect it won't show in profiles of compil
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/69975
>From 0270c76e779457486ee89f100db2b7151832c290 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Tue, 10 Oct 2023 14:16:13 -0700
Subject: [PATCH 1/4] [clang][modules] Make `DIAGNOSTIC_OPTIONS` skippable
---
https://github.com/ChuanqiXu9 commented:
Besides deps scanning, have you tried to enable these option to compile with
clang modules? I mean, if it is safe to enable such options at compilation
times, it looks a valid optimization for C++20 modules too. If it is not safe
to do so, I think we ne
@@ -2944,6 +2944,10 @@ def fno_modules_validate_textual_header_includes :
MarshallingInfoNegativeFlag>,
HelpText<"Do not enforce -fmodules-decluse and private header restrictions
for textual headers. "
"This flag will be removed in a future Clang release.">;
+d
@@ -2944,6 +2944,10 @@ def fno_modules_validate_textual_header_includes :
MarshallingInfoNegativeFlag>,
HelpText<"Do not enforce -fmodules-decluse and private header restrictions
for textual headers. "
"This flag will be removed in a future Clang release.">;
+d
@@ -1212,9 +1212,12 @@ void ASTWriter::writeUnhashedControlBlock(Preprocessor
&PP,
Record.clear();
}
+ const auto &HSOpts = PP.getHeaderSearchInfo().getHeaderSearchOpts();
+
// Diagnostic options.
const auto &Diags = Context.getDiagnostics();
const DiagnosticO
@@ -2944,6 +2944,10 @@ def fno_modules_validate_textual_header_includes :
MarshallingInfoNegativeFlag>,
HelpText<"Do not enforce -fmodules-decluse and private header restrictions
for textual headers. "
"This flag will be removed in a future Clang release.">;
+d
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/69975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
Deserialization of the `DIAGNOSTIC_OPTIONS` and `HEADER_SEARCH_PATHS` records
is slow and done for every transitively loaded PCM. Deserialization of these
records cannot be skipped, because the words are
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/69975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/69975
Deserialization of the `DIAGNOSTIC_OPTIONS` and `HEADER_SEARCH_PATHS` records
is slow and done for every transitively loaded PCM. These records cannot be
skipped, because the words are VBR6-encoded and we d
17 matches
Mail list logo
