[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-28 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/66389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-28 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Closing. I want to achieve this by fixing the underlying issues: * Speeding up `SLocEntry` deserialization (https://github.com/llvm/llvm-project/pull/66962, https://github.com/llvm/llvm-project/pull/66966). * Either adding caching to `DependencyScanningWorkerFilesystem::getR

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-15 Thread Ben Langmuir via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); benlangmuir wrote: > This

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-15 Thread Jan Svoboda via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); jansvoboda11 wrote: > > Th

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-15 Thread Ben Langmuir via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); benlangmuir wrote: > The c

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-15 Thread Jan Svoboda via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); jansvoboda11 wrote: > Is t

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-15 Thread Ben Langmuir via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); benlangmuir wrote: Is the

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-15 Thread Jan Svoboda via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); jansvoboda11 wrote: I don'

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-14 Thread Ben Langmuir via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); benlangmuir wrote: This wo

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-14 Thread Jan Svoboda via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); jansvoboda11 wrote: Are yo

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-14 Thread Ben Langmuir via cfe-commits
@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl &Path) { + FileManager &FM = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); benlangmuir wrote: I'm not

[clang] [clang][deps] Load module map file from PCM (PR #66389)

2023-09-14 Thread Ben Langmuir via cfe-commits
@@ -482,16 +482,9 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module *M) { MD.ID.ModuleName = M->getFullModuleName(); MD.IsSystem = M->IsSystem; - ModuleMap &ModMapInfo = - MDC.ScanInstance.getPreprocessor().getHeaderSearchInfo().getModuleMap(); - - Optiona