llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building
`clang` at step 10 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/73/builds/5193
Here is the r
steakhal wrote:
> PS: Should this be cherry-picked into 19?
Requested the backport in https://github.com/llvm/llvm-project/pull/107841
https://github.com/llvm/llvm-project/pull/107764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/107764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/107764
>From a43b9b74ac253c0072498007cf56ed57d8255143 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sun, 8 Sep 2024 11:52:28 -0400
Subject: [PATCH 1/2] [clang][analyzer] Fix #embed crash
Fix #107724.
---
c
@@ -0,0 +1,9 @@
+// RUN: %clang_analyze_cc1 -std=c23
-analyzer-checker=core,debug.ExprInspection -verify %s
+
+// expected-no-diagnostics
+
+int main() {
+const unsigned char SelfBytes[] = {
+#embed "embed.c"
+};
+}
steakhal wrote:
```suggestion
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/107764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
LGTM. I knew about this issue, thanks for the fix!
There is more for a proper fix but it's better than crashing.
https://github.com/llvm/llvm-project/pull/107764
___
cfe-commits mailing list
cfe-c
https://github.com/NagyDonat commented:
LGTM, there is no reason to crash on `#embed`.
I think it would be nice to have a few testcases that show the behavior of the
analyzer around `#embed`:
- Can we produce bug reports if there is an (unrelated) `#embed` expression on
the execution path? Or
nicovank wrote:
PS: Should this be cherry-picked into 19?
https://github.com/llvm/llvm-project/pull/107764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nicolas van Kempen (nicovank)
Changes
Fix #107724.
---
Full diff: https://github.com/llvm/llvm-project/pull/107764.diff
2 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Core/ExprEngine.cpp (+1-4)
- (added) clang/test/Analysis/
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/107764
Fix #107724.
>From a43b9b74ac253c0072498007cf56ed57d8255143 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sun, 8 Sep 2024 11:52:28 -0400
Subject: [PATCH] [clang][analyzer] Fix #embed crash
Fix #10
11 matches
Mail list logo