https://github.com/AmrDeveloper closed
https://github.com/llvm/llvm-project/pull/138592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev approved this pull request.
https://github.com/llvm/llvm-project/pull/138592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, but I'd appreciate confirmation from an OpenMP code owner too.
https://github.com/llvm/llvm-project/pull/138592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138592
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
@@ -11526,6 +11526,8 @@ def note_omp_collapse_ordered_expr : Note<
"as specified in %select{'collapse'|'ordered'|'collapse' and 'ordered'}0
clause%select{||s}0">;
def err_omp_negative_expression_in_clause : Error<
"argument to '%0' clause must be a %select{non-negative|str
@@ -521,6 +521,8 @@ Improvements to Clang's diagnostics
- Fixed a duplicate diagnostic when performing typo correction on function
template
calls with explicit template arguments. (#GH139226)
+- An error is now emitted when OpenMP ``collapse`` and ``ordered`` clauses has
e
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138592
>From 793bd974b779450a84c72d54237067ab56a59cdc Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Mon, 5 May 2025 23:01:02 +0200
Subject: [PATCH 1/5] [clang][OpenMP] Add error for large expr in collapse
---
@@ -15901,6 +15901,13 @@ ExprResult
SemaOpenMP::VerifyPositiveIntegerConstantInClause(
<< E->getSourceRange();
return ExprError();
}
+
+ if (!Result.isRepresentableByInt64()) {
AmrDeveloper wrote:
In our implementation, yes, because we const ev
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138592
>From 793bd974b779450a84c72d54237067ab56a59cdc Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Mon, 5 May 2025 23:01:02 +0200
Subject: [PATCH 1/4] [clang][OpenMP] Add error for large expr in collapse
---
@@ -15901,6 +15901,13 @@ ExprResult
SemaOpenMP::VerifyPositiveIntegerConstantInClause(
<< E->getSourceRange();
return ExprError();
}
+
+ if (!Result.isRepresentableByInt64()) {
shafik wrote:
So these are always 64 bit integers? This:
https://w
@@ -11523,6 +11523,8 @@ def note_omp_collapse_ordered_expr : Note<
"as specified in %select{'collapse'|'ordered'|'collapse' and 'ordered'}0
clause%select{||s}0">;
def err_omp_negative_expression_in_clause : Error<
"argument to '%0' clause must be a %select{non-negative|str
AmrDeveloper wrote:
> Thank you for the fix! I've added a few more reviewers. This is a pretty
> general problem, so I think we may want additional test coverage for
> basically any of the OpenMP clauses which accept an integer argument. For
> example, this is another related issue: #139268 --
AaronBallman wrote:
Thank you for the fix! I've added a few more reviewers. This is a pretty
general problem, so I think we may want additional test coverage for basically
any of the OpenMP clauses which accept an integer argument. For example, this
is another related issue: https://github.com
AmrDeveloper wrote:
> In addition to the collapse clause, the ordered clause also seems to have the
> same problem. For example, does your patch also fix the following crash? If
> so, you also need tests regarding the ordered clause.
> https://godbolt.org/z/96sa5jxff
>
> ```c++
> void f(void)
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138592
>From af3e49f1290c61d5856a5ddf600cfd19ef485e25 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Mon, 5 May 2025 23:01:02 +0200
Subject: [PATCH 1/3] [clang][OpenMP] Add error for large expr in collapse
---
k-arrows wrote:
In addition to the collapse clause, the ordered clause also seems to have the
same problem. For example, does your patch also fix the following crash? If so,
you also need tests regarding the ordered clause.
https://godbolt.org/z/96sa5jxff
```cpp
void f(void) {
#pragma omp for o
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138592
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
https://github.com/AmrDeveloper edited
https://github.com/llvm/llvm-project/pull/138592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AmrDeveloper edited
https://github.com/llvm/llvm-project/pull/138592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
19 matches
Mail list logo
