https://github.com/ddpagan closed
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan updated
https://github.com/llvm/llvm-project/pull/121814
>From d2747bc68455a3dab6ffb47da8851fd1db3f59b5 Mon Sep 17 00:00:00 2001
From: Dave Pagan
Date: Fri, 22 Nov 2024 10:35:40 -0600
Subject: [PATCH 1/6] [clang][OpenMP] Add 'align' modifier for 'allocate'
clause
Th
alexey-bataev wrote:
Rebase? And commit after rebase, it is approved already
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan updated
https://github.com/llvm/llvm-project/pull/121814
>From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001
From: Dave Pagan
Date: Fri, 22 Nov 2024 10:35:40 -0600
Subject: [PATCH 1/6] [clang][OpenMP] Add 'align' modifier for 'allocate'
clause
Th
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan updated
https://github.com/llvm/llvm-project/pull/121814
>From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001
From: Dave Pagan
Date: Fri, 22 Nov 2024 10:35:40 -0600
Subject: [PATCH 1/5] [clang][OpenMP] Add 'align' modifier for 'allocate'
clause
Th
@@ -17153,11 +17155,25 @@ OMPClause
*SemaOpenMP::ActOnOpenMPVarListClause(OpenMPClauseKind Kind,
case OMPC_has_device_addr:
Res = ActOnOpenMPHasDeviceAddrClause(VarList, Locs);
break;
- case OMPC_allocate:
-Res = ActOnOpenMPAllocateClause(Data.DepModOrTailExpr,
ddpagan wrote:
Made changes requested by Alexey.
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan updated
https://github.com/llvm/llvm-project/pull/121814
>From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001
From: Dave Pagan
Date: Fri, 22 Nov 2024 10:35:40 -0600
Subject: [PATCH 1/4] [clang][OpenMP] Add 'align' modifier for 'allocate'
clause
Th
@@ -11824,10 +11824,14 @@ void OMPClauseReader::VisitOMPMapClause(OMPMapClause
*C) {
}
void OMPClauseReader::VisitOMPAllocateClause(OMPAllocateClause *C) {
- C->setAllocatorModifier(Record.readEnum());
+ C->setFirstAllocateModifier(
+ static_cast(Record.readInt()));
+
@@ -7924,10 +7924,12 @@ void OMPClauseWriter::VisitOMPMapClause(OMPMapClause
*C) {
void OMPClauseWriter::VisitOMPAllocateClause(OMPAllocateClause *C) {
Record.push_back(C->varlist_size());
- Record.writeEnum(C->getAllocatorModifier());
+ Record.push_back(C->getFirstAlloca
@@ -4530,32 +4530,89 @@ static bool parseStepSize(Parser &P,
SemaOpenMP::OpenMPVarListDataTy &Data,
}
/// Parse 'allocate' clause modifiers.
-/// If allocator-modifier exists, return an expression for it and set
-/// Data field noting modifier was specified.
-///
+/// I
ddpagan wrote:
Thanks for reviewing, Alexey. Made the requested changes.
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan updated
https://github.com/llvm/llvm-project/pull/121814
>From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001
From: Dave Pagan
Date: Fri, 22 Nov 2024 10:35:40 -0600
Subject: [PATCH 1/3] [clang][OpenMP] Add 'align' modifier for 'allocate'
clause
Th
@@ -5285,6 +5285,7 @@ static void checkAllocateClauses(Sema &S, DSAStackTy
*Stack,
}
for (OMPClause *C : AllocateRange) {
auto *AC = cast(C);
+// TODO: Check alignment?
ddpagan wrote:
Old note to myself. As far as I know there aren't any checks r
@@ -4530,32 +4530,87 @@ static bool parseStepSize(Parser &P,
SemaOpenMP::OpenMPVarListDataTy &Data,
}
/// Parse 'allocate' clause modifiers.
-/// If allocator-modifier exists, return an expression for it and set
-/// Data field noting modifier was specified.
-///
+/// I
@@ -4530,32 +4530,87 @@ static bool parseStepSize(Parser &P,
SemaOpenMP::OpenMPVarListDataTy &Data,
}
/// Parse 'allocate' clause modifiers.
-/// If allocator-modifier exists, return an expression for it and set
-/// Data field noting modifier was specified.
-///
+/// I
@@ -4530,32 +4530,87 @@ static bool parseStepSize(Parser &P,
SemaOpenMP::OpenMPVarListDataTy &Data,
}
/// Parse 'allocate' clause modifiers.
-/// If allocator-modifier exists, return an expression for it and set
-/// Data field noting modifier was specified.
-///
+/// I
@@ -5285,6 +5285,7 @@ static void checkAllocateClauses(Sema &S, DSAStackTy
*Stack,
}
for (OMPClause *C : AllocateRange) {
auto *AC = cast(C);
+// TODO: Check alignment?
alexey-bataev wrote:
What are the missing checks here?
https://github.com/llv
ddpagan wrote:
> Update OpenMPSupport.rst
New 'align' modifier added to implemented features list.
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/ddpagan updated
https://github.com/llvm/llvm-project/pull/121814
>From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001
From: Dave Pagan
Date: Fri, 22 Nov 2024 10:35:40 -0600
Subject: [PATCH 1/2] [clang][OpenMP] Add 'align' modifier for 'allocate'
clause
Th
alexey-bataev wrote:
Update OpenMPSupport.rst
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ddpagan wrote:
NOTE: OpenMP Support doc will be updated as well in a subsequent patch.
https://github.com/llvm/llvm-project/pull/121814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: David Pagan (ddpagan)
Changes
The 'align' modifier is now accepted in the 'allocate' clause. Added LIT tests
covering codegen, PCH, template handling, and serialization for 'align'
modifier.
Added support for align-modifier to release no
https://github.com/ddpagan created
https://github.com/llvm/llvm-project/pull/121814
The 'align' modifier is now accepted in the 'allocate' clause. Added LIT tests
covering codegen, PCH, template handling, and serialization for 'align'
modifier.
Added support for align-modifier to release note
25 matches
Mail list logo
