[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-07-09 Thread Victor Lomuller via cfe-commits
Naghasan wrote: ping https://github.com/llvm/llvm-project/pull/94934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread Victor Lomuller via cfe-commits
Naghasan wrote: Still I forgot to answer this point as well... > Are there ever point releases that might mea +ptx78 should actually expand to > 780 rather than 78? not sure what you exactly mean with your question. I guess we can mirror the cuda arch macro so, major * 100 + minor * 10, no op

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread Victor Lomuller via cfe-commits
https://github.com/Naghasan edited https://github.com/llvm/llvm-project/pull/94934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread Victor Lomuller via cfe-commits
Naghasan wrote: Thanks for setting the reviewer > Can you please include rationale for why this this name e.g. why not > __NVPTX_VERSION__? `NVPTX` is the name of the LLVM backend, `PTX` is the name of assembly which have a version hence `__PTX_VERSION__`. Happy to use a better name, but it i

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread via cfe-commits
ldrumm wrote: Can you please include rationale for why this this name e.g. why not `__NVPTX_VERSION__`? How does it relate to `__CUDA_ARCH__`, and why is `__CUDA_ARCH__` not sufficient? Are there ever point releases that might mean we should max +ptx78 should actually expand to `780` rather th

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-18 Thread Victor Lomuller via cfe-commits
Naghasan wrote: @Artem-B could you have a look ? I think you are the most relevant for this, thanks. (Sorry I can't manage assignment) https://github.com/llvm/llvm-project/pull/94934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Victor Lomuller (Naghasan) Changes Define __PTX_VERSION__ macro to indicate the used PTX version. Usually each new PTX version brings a new sm version and the associated instructions. However, some of these instructions can also be made a

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-09 Thread Victor Lomuller via cfe-commits
https://github.com/Naghasan created https://github.com/llvm/llvm-project/pull/94934 Define __PTX_VERSION__ macro to indicate the used PTX version. Usually each new PTX version brings a new sm version and the associated instructions. However, some of these instructions can also be made avialabl