https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
We talked about this at the Clang Language WG meeting and there were a lot of
good arguments for either formatting/reorganizing as separate commits or for
formatting/reorganizing in the same commit. If the folks doing a downstream
pulldown are experienced with the code base
cor3ntin wrote:
Please run clang-format as a separate PR (before this one) - this will help
folks deal with merge conflicts. Thanks
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
> That's because you are filtering only opened PRs, not including drafts PRs.
> For example there is this draft PR:
> https://github.com/llvm/llvm-project/pull/81095/files
(I think my recent PR https://github.com/llvm/llvm-project/pull/82310 now
supersedes my two draft PRs, and
tstellar wrote:
This will make backports more difficult, but I think it's OK. If we wanted to
avoid impacting backports, we'd have to wait ~10 weeks to merge this, but that
doesn't seem practical.
https://github.com/llvm/llvm-project/pull/82217
___
to268 wrote:
That's because you are filtering only opened PRs, not including drafts PRs.
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
Funny enough, search in the web versions shows only 23 PRs:
https://github.com/llvm/llvm-project/pulls?q=is%3Apr+is%3Aopen+%22clang%2Finclude%2Fclang%2FSema%2FSema.h%22
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mai
to268 wrote:
FYI: There is currently 26 PRs that impacts `Sema.h`, bellow is the bash one
liner with GitHub CLI to count the numbers of impacted PRs and another one to
list links to impacted PRs.
- Count all impacted PRs:
```bash
gh pr list --json files --jq '.[] | {paths: [.files[].path | sel
erichkeane wrote:
> @erichkeane
>
> > That said, waiting until after 18 is perhaps a good diea.
>
> Resolving merge conflicts that will arise in the meantime is not going to be
> trivial, but should be doable in a reasonable time. So I'm willing to wait.
>
I'm glad to hear that! I'm hopeful
Endilll wrote:
@erichkeane
> That said, waiting until after 18 is perhaps a good diea.
Resolving merge conflicts that will arise in the meantime is not going to be
trivial, but should be doable in a reasonable time. So I'm willing to wait.
> I MIGHT suggest private followed by public? It is
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
That's how API reference looks with this patch. I specifically picked small
groups to showcase member grouping.
Existing API reference can be found here:
https://clang.llvm.org/dox
erichkeane wrote:
> This is going to be rather disruptive on downstream projects. At least we
> should wait until after the release of clang 18 to merge it, to avoid endless
> merge conflicts
For the most part, git will handle these pretty well on downstreams I think,
and as they are declarat
cor3ntin wrote:
This is going to be rather disruptive on downstream projects.
At least we should wait until after the release of clang 18 to merge it, to
avoid endless merge conflicts
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mai
tbaederr wrote:
> 11,427 additions, 11,178 deletions not shown because the diff is too large.
> Please use a local Git client to view these changes.
Never seen that before, haha.
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing
Endilll wrote:
I've built doxygen documentation locally. Now I see what I expected so see
(proper member groups).
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dd7386d85f11cf6ad911b9827c7018fb08c6c205
681cecc15a472aede4c6d4bf1e75c755fdcce3e5 --
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/82217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch regroups declarations in `Sema` based on the file they are
implemented in (e.g. `SemaChecking.cpp`). This allows to logically split `Sema`
in 42 groups. Table of contents added at the very b
23 matches
Mail list logo
