[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-20 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: > [#120341 > (comment)](https://github.com/llvm/llvm-project/pull/120341#discussion_r1893822845) oops, I saw this after I hit the merge button. I will do it in a follow-up commit. https://github.com/llvm/llvm-project/pull/120643 ___

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-20 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/120643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-20 Thread Jon Roelofs via cfe-commits
jroelofs wrote: may as well address @nikic's post-commit suggestion to move this out of the header, and into a source file, while you're here: https://github.com/llvm/llvm-project/pull/120341#discussion_r1893822845 https://github.com/llvm/llvm-project/pull/120643 __

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/120643 >From ada689aff13ea5c582280ce72d3e735ca07caf60 Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Thu, 19 Dec 2024 13:44:42 -0800 Subject: [PATCH] [clang][NFC] Fix the static assertion in 4797437 In the previ

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d33a2c58112bdd74225b0ff4f07acc49bed7e6ea d1b45d14157f9adf4ec8f41840f269b262ee8da6 --e

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/120643 >From d1b45d14157f9adf4ec8f41840f269b262ee8da6 Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Thu, 19 Dec 2024 13:44:42 -0800 Subject: [PATCH] [clang][NFC] Fix the static assertion in 4797437 In the previ

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/120643 >From dd71be83e763128ce432d3a77e17abb439575f4d Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Thu, 19 Dec 2024 13:44:42 -0800 Subject: [PATCH] [clang][NFC] Fix the static assertion in 4797437 In the previ

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Jon Roelofs via cfe-commits
@@ -114,10 +114,9 @@ class alignas(void *) Stmt { #define STMT(CLASS, PARENT) #define STMT_RANGE(BASE, FIRST, LAST) #define LAST_STMT_RANGE(BASE, FIRST, LAST) \ - static_assert(

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/120643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/120643 >From b057ae37da2426e4ad04297600ce9bdf7d9a31c4 Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Thu, 19 Dec 2024 13:44:42 -0800 Subject: [PATCH] [clang][NFC] Fix the static assertion in 4797437 In the previ

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Jon Roelofs via cfe-commits
@@ -114,10 +114,10 @@ class alignas(void *) Stmt { #define STMT(CLASS, PARENT) #define STMT_RANGE(BASE, FIRST, LAST) #define LAST_STMT_RANGE(BASE, FIRST, LAST) \ - static_assert(

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ziqing Luo (ziqingluo-90) Changes In the previous commit 4797437463e63ee289a1ff1904cfb7b2fe6cb4c2, I used `llvm::isInt(StmtClass::LAST##Class)` to test if `StmtClass` is strictly bounded by the an unsigned integer of 'NumStmt

[clang] [clang][NFC] Fix the static assertion in 4797437 (PR #120643)

2024-12-19 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 created https://github.com/llvm/llvm-project/pull/120643 In the previous commit 4797437463e63ee289a1ff1904cfb7b2fe6cb4c2, I used `llvm::isInt(StmtClass::LAST##Class)` to test if `StmtClass` is strictly bounded by the an unsigned integer of 'NumStmtBits'. That i