hazohelet wrote:
Thanks for the heads up. I'll request backporting in a few hours when buildbots
finish running tests.
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
tbaederr wrote:
Thanks. Don't forget to trigger a backport to clang 17
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet closed
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet updated
https://github.com/llvm/llvm-project/pull/67817
>From 7f4db6d81f24adb72416e79bde65a1a13d9a82b8 Mon Sep 17 00:00:00 2001
From: Takuya Shimizu
Date: Fri, 29 Sep 2023 23:49:11 +0900
Subject: [PATCH 1/4] [clang][ExprConst] Fix crash on uninitialized array
subob
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hazohelet wrote:
Ping
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet updated
https://github.com/llvm/llvm-project/pull/67817
>From acb5d8286335f85732ede8d33ac2529e13a3f61b Mon Sep 17 00:00:00 2001
From: Takuya Shimizu
Date: Fri, 29 Sep 2023 23:49:11 +0900
Subject: [PATCH 1/4] [clang][ExprConst] Fix crash on uninitialized array
subob
@@ -404,7 +404,7 @@ bool CheckPure(InterpState &S, CodePtr OpPC, const
CXXMethodDecl *MD) {
static void DiagnoseUninitializedSubobject(InterpState &S, const SourceInfo
&SI,
const FieldDecl *SubObjDecl) {
assert(SubObjDecl && "Subob
https://github.com/hazohelet updated
https://github.com/llvm/llvm-project/pull/67817
>From acb5d8286335f85732ede8d33ac2529e13a3f61b Mon Sep 17 00:00:00 2001
From: Takuya Shimizu
Date: Fri, 29 Sep 2023 23:49:11 +0900
Subject: [PATCH 1/3] [clang][ExprConst] Fix crash on uninitialized array
subob
@@ -2411,10 +2411,15 @@ static bool
CheckEvaluationResult(CheckEvaluationResultKind CERK,
const FieldDecl *SubobjectDecl,
CheckedTemporaries &CheckedTemps) {
if (!Value.hasValue()) {
-assert(SubobjectDec
@@ -2411,10 +2411,15 @@ static bool
CheckEvaluationResult(CheckEvaluationResultKind CERK,
const FieldDecl *SubobjectDecl,
CheckedTemporaries &CheckedTemps) {
if (!Value.hasValue()) {
-assert(SubobjectDec
hazohelet wrote:
Ping
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2411,10 +2411,15 @@ static bool
CheckEvaluationResult(CheckEvaluationResultKind CERK,
const FieldDecl *SubobjectDecl,
CheckedTemporaries &CheckedTemps) {
if (!Value.hasValue()) {
-assert(SubobjectDec
https://github.com/shafik commented:
I am a bit concerned we don't fully understand how to recover the old
diagnostic. I left a comment that I think may help but I think we need to
understand this a bit better before committing to a fix.
https://github.com/llvm/llvm-project/pull/67817
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2411,10 +2411,15 @@ static bool
CheckEvaluationResult(CheckEvaluationResultKind CERK,
const FieldDecl *SubobjectDecl,
CheckedTemporaries &CheckedTemps) {
if (!Value.hasValue()) {
-assert(SubobjectDec
tbaederr wrote:
Unfortunate, but the changes look good to me. Since the crash was introduced in
clang 17, this should also be backported.
https://github.com/llvm/llvm-project/pull/67817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/hazohelet updated
https://github.com/llvm/llvm-project/pull/67817
>From e331f12dd6f8976df44855619ab740aee86ddd2e Mon Sep 17 00:00:00 2001
From: Takuya Shimizu
Date: Fri, 29 Sep 2023 23:49:11 +0900
Subject: [PATCH 1/2] [clang][ExprConst] Fix crash on uninitialized array
subob
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
https://reviews.llvm.org/D146358 was assuming that all subobjects have
their own name (`SubobjectDecl`), but it was not true for array
elements.
Fixes https://github.com/llvm/llvm-project/issues/67317
---
Full diff: https://github.com/llv
https://github.com/hazohelet created
https://github.com/llvm/llvm-project/pull/67817
https://reviews.llvm.org/D146358 was assuming that all subobjects have
their own name (`SubobjectDecl`), but it was not true for array
elements.
Fixes https://github.com/llvm/llvm-project/issues/67317
>From e
20 matches
Mail list logo
