[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

zygoloid wrote: See https://github.com/llvm/llvm-project/issues/58754#issuecomment-2354048986 -- this introduces a miscompile by producing comparison results at compile time that differ from the results at runtime. Please can this be reverted? https://github.com/llvm/llvm-project/pull/106733 _

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/106733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/106733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/106733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/106733 >From 7dbb01805663a6671c61330c5abc04c44146cc24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 30 Aug 2024 15:52:48 +0200 Subject: [PATCH] [clang][ExprConst] Allow comparisons with strin

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/106733 >From 73af678c4c405cff16d5baf668e78e736bb1d228 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 30 Aug 2024 15:52:48 +0200 Subject: [PATCH] [clang][ExprConst] Allow comparisons with strin

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Don't diagnose them, but literals still have distinct addresses. Fixes https://github.com/llvm/llvm-project/issues/58754 --- Full diff: https://github.com/llvm/llvm-project/pull/106733.diff 3 Files Affecte

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/106733 Don't diagnose them, but literals still have distinct addresses. Fixes https://github.com/llvm/llvm-project/issues/58754 >From b77e5f928ff6acd2c44bfc27c178aa4121a24228 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?