[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

petrhosek wrote: > To be clear, are you asking _me_ to make a followup PR to change that > identifier in this already-landed patch, or are you going to do it? > > (Just to avoid the situation where both of us do it, or both of us think the > other is going to) If you have time to implement it

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

statham-arm wrote: To be clear, are you asking _me_ to make a followup PR to change that identifier in this already-landed patch, or are you going to do it? (Just to avoid the situation where both of us do it, or both of us think the other is going to) https://github.com/llvm/llvm-project/pul

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

petrhosek wrote: I think `Error` and `Warning` would be more consistent actually, especially if `-Werror` also applied to `Warning`; ideally we would also have a custom warning type so you could do e.g. `-Wno-multilib-warning` to suppress these warnings. https://github.com/llvm/llvm-project/p

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

petrhosek wrote: This is just a nit, but is there a reason for calling this `FatalError` rather than just `Error`? To me "fatal" usually means something went seriously wrong, but in this case it's just the fact the combination of flags is not supported and in the driver we usually just refer t

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/4754 Here is the relevant piece of the build log for

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

statham-arm wrote: For the record, that also looks spurious: again it's completely unrelated to this patch, and also, [build 4752](https://lab.llvm.org/buildbot/#/builders/123/builds/4752) of the same buildbot failed in the same way, two commits earlier. It looks more likely that that test is

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

statham-arm wrote: There are two failed CI checks here, but they both seem to be complaining about a libc++ test called `pstl.merge.pass.cpp`, which is surely completely unrelated to this clang driver change specific to bare-metal multilib setups. https://github.com/llvm/llvm-project/pull/1056

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

https://github.com/statham-arm closed https://github.com/llvm/llvm-project/pull/105684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

https://github.com/ostannard approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/105684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/105684 >From 806ac0bee0478fda32ec0bf5bfb9e28e1bef618d Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Wed, 21 Aug 2024 15:50:32 +0100 Subject: [PATCH 1/3] [clang][Driver] Add a custom error option in multilib.ya

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

@@ -130,7 +143,7 @@ class MultilibSet { /// Select compatible variants, \returns false if none are compatible bool select(const Multilib::flags_list &Flags, MaskRay wrote: For other parts of Driver, I think `const Driver &` is more commonly used as the f

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

https://github.com/MaskRay commented: I'm starting a 3-week vacation this Friday and will have limited availability. Happy for other reviewers to approve. https://github.com/llvm/llvm-project/pull/105684 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

@@ -0,0 +1,63 @@ +# REQUIRES: shell +# UNSUPPORTED: system-windows + +# RUN: rm -rf %T/baremetal_multilib MaskRay wrote: do not use `%T` https://llvm.org/docs/CommandGuide/lit.html#substitutions just use `rm -rf %t && mkdir %t` for what you do with `%T/baremeta

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/105684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Simon Tatham (statham-arm) Changes Sometimes a collection of multilibs has a gap in it, where a set of driver command-line options can't work with any of the available libraries. For example, the Arm MVE extension requires special startup

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

https://github.com/statham-arm created https://github.com/llvm/llvm-project/pull/105684 Sometimes a collection of multilibs has a gap in it, where a set of driver command-line options can't work with any of the available libraries. For example, the Arm MVE extension requires special startup co