https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/131976
>From 163c73d21af736c94f1bb8f8c63caf96e127aba5 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 19 Mar 2025 13:21:48 +0800
Subject: [PATCH 1/3] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo
fixes https://g
https://github.com/benshi001 closed
https://github.com/llvm/llvm-project/pull/131976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/131976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -114,3 +114,13 @@ struct s15 fooa(char a, char b) {
x.arr[1] = b;
return x;
}
+
+struct s8_t {
+ char a;
+};
+
+// AVR: define {{.*}} i8 @foob(i8 {{.*}})
+// TINY define {{.*}} i8 @foob(i8 {{.*}})
benshi001 wrote:
fixed. thanks!
https://github.com/l
https://github.com/jacquesguan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/131976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -114,3 +114,13 @@ struct s15 fooa(char a, char b) {
x.arr[1] = b;
return x;
}
+
+struct s8_t {
+ char a;
+};
+
+// AVR: define {{.*}} i8 @foob(i8 {{.*}})
+// TINY define {{.*}} i8 @foob(i8 {{.*}})
efriedma-quic wrote:
```suggestion
// AVR: define {{
https://github.com/Patryk27 approved this pull request.
https://github.com/llvm/llvm-project/pull/131976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/131976
>From 163c73d21af736c94f1bb8f8c63caf96e127aba5 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 19 Mar 2025 13:21:48 +0800
Subject: [PATCH 1/2] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo
fixes https://g
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/131976
>From 163c73d21af736c94f1bb8f8c63caf96e127aba5 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 19 Mar 2025 13:21:48 +0800
Subject: [PATCH 1/2] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo
fixes https://g
@@ -114,3 +114,13 @@ struct s15 fooa(char a, char b) {
x.arr[1] = b;
return x;
}
+
+struct s8_t {
+ char a;
+};
+
+// AVR-NOT: {{.*}} signext
+// TINY-NOT: {{.*}} signext
efriedma-quic wrote:
Can you rewrite this test to avoid "NOT"? Something like `//
@@ -135,7 +135,8 @@ class AVRTargetCodeGenInfo : public TargetCodeGenInfo {
if (GV->isDeclaration())
return;
const auto *FD = dyn_cast_or_null(D);
-if (!FD) return;
+if (!FD)
efriedma-quic wrote:
Please don't reformat code that isn't rele
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Ben Shi (benshi001)
Changes
fixes https://github.com/llvm/llvm-project/issues/131967
---
Full diff: https://github.com/llvm/llvm-project/pull/131976.diff
2 Files Affected:
- (modified) clang/lib/CodeGen/Targets/AVR.cpp (+4-3)
-
https://github.com/benshi001 created
https://github.com/llvm/llvm-project/pull/131976
fixes https://github.com/llvm/llvm-project/issues/131967
>From 163c73d21af736c94f1bb8f8c63caf96e127aba5 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 19 Mar 2025 13:21:48 +0800
Subject: [PATCH] [clang][Co
13 matches
Mail list logo
