https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske approved this pull request.
This reordering is not a significant feature (and may change in the future) and
no test existed before, it is enough (if this exists) if there is a GDB test
for the crash.
https://github.com/llvm/llvm-project/pull/77079
__
Michael137 wrote:
Tried to find a way to test "objective-c fields aren't reordered". After
talking to some objective-c experts, there doesn't seem to be a good way to
force such "incorrect field order", because it's strictly an in-order language.
Reducing the LLDB crashes has been tricky becau
https://github.com/adrian-prantl approved this pull request.
Test would be nice, but generally this looks like a reasonable modification.
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
Michael137 wrote:
I guess if there's some other type of ObjC decl that could trigger the
re-ordering that would be useful.
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
Michael137 wrote:
> I can not check what caused exactly the problems but the change looks correct
> and in change D154764 there seems to be no reason for re-ordering at
> non-record objects. As an improvement, some tests could be added that check
> for re-ordering at `RecordDecl` and (this is
balazske wrote:
I can not check what caused exactly the problems but the change looks correct
and in change D154764 there seems to be no reason for re-ordering at non-record
objects. As an improvement, some tests could be added that check for
re-ordering at `RecordDecl` and (this is the more
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/77079
>From 544e2b12695fa572b08abc8efdceeadd63ebbde5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 5 Jan 2024 10:41:55 +
Subject: [PATCH 1/2] [clang][ASTImporter] Only reorder fields of RecordDecls
Pri
Michael137 wrote:
Need to sort out some test failures
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
Prior to `e9536698720ec524cc8b72599363622bc1a31558`
(https://reviews.llvm.org/D154764) we only re-ordered the fields of
`RecordDecl`s. The change refactored this logic to make sure `FieldDecl`s are
impor
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/77079
Prior to `e9536698720ec524cc8b72599363622bc1a31558`
(https://reviews.llvm.org/D154764) we only re-ordered the fields of
`RecordDecl`s. The change refactored this logic to make sure `FieldDecl`s are
imported
13 matches
Mail list logo
