=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE closed
https://github.com/llvm/llvm-project/pull/67572
___
cfe-commits mailing list
cfe-commits@l
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/67572
__
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
DonatNagyE wrote:
I'll merge this change soon, when I'll start to work on the followup commit
(unless there is additional feedback until then). Thanks for the reviews!
h
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001
From: =?UTF-
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ Bug
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ Bug
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bou
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bou
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/67572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
No blocking comments.
https://github.com/llvm/llvm-project/pull/67572
___
cfe-commits mailing list
cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
DonatNagyE wrote:
@steakhal Could you briefly look at this commit? I'm open to modifying it if
you say that it's necessary, but if I could merge it, then I'd be able to
rebase and finalize my next commit (which adds det
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bou
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 6 Sep 2023 13:
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b22917e6e2a0aec05474f58e64b7e87d1ea
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType T
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 6 Sep 2023 13:39:27 +0200
Subject: [PAT
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
DonatNagyE wrote:
After some delays (I had a short vacation, then forgot about this patch) I
finally got some test results... and they revealed that it was causing lots of
segfaults. @steakhal thanks for asking for the experimental confirmation, it
was useful!
After fixing the buggy line and
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
@@ -32,42 +32,72 @@ using namespace taint;
namespace {
class ArrayBoundCheckerV2 :
public Checker {
- mutable std::unique_ptr BT;
- mutable std::unique_ptr TaintBT;
+ BugType BT{this, "Out-of-bound access"};
+ BugType TaintBT{this, "Out-of-bound access", categories::Tai
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/67572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/67572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 6 Sep 2023 13:39:27 +0200
Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 583b6c3bf838bf74899a1ce5ab53b3722ddb8e66 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 6 Sep 2023 13:39:27 +0200
Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2
steakhal wrote:
> I'm confident that this patch is NFC, but my claim is based on theoretical
> reasoning (a.k.a. "I think I didn't make a mistake"). I have a background in
> theoretical mathematics, so for me "I have a rough a proof in my head" is
> intuitively stronger than "I verified it on
DonatNagyE wrote:
I'm confident that this patch is NFC, but my claim is based on theoretical
reasoning (a.k.a. "I think I didn't make a mistake"). I have a background in
theoretical mathematics, so for me "I have a rough a proof in my head" is
intuitively stronger than "I verified it on some a
steakhal wrote:
I remember I looked this once. I postponed my comments because I was expecting
some numbers or confirmation of that this patch is indeed NFC, thus no report
or notes change. I'm not sure if this actually holds, given the changes, but
let me know in any case.
BTW I'm fine with
https://github.com/gamesh411 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 448999ecab28ea4d9768c1a8fa5fb4bb25e4bd32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 6 Sep 2023 13:39:27 +0200
Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67572
>From 2b6a23c71a41bc07e37b4bed2cfef8b790e84631 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 6 Sep 2023 13:39:27 +0200
Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
I'm planning to improve diagnostics generation in `ArrayBoundCheckerV2` but
before that I'm refactoring the source code to clean up some over-complicated
code and an inaccurate comment.
Changes in this commit:
- Remove the `mutable std::u
https://github.com/DonatNagyE created
https://github.com/llvm/llvm-project/pull/67572
I'm planning to improve diagnostics generation in `ArrayBoundCheckerV2` but
before that I'm refactoring the source code to clean up some over-complicated
code and an inaccurate comment.
Changes in this commi
38 matches
Mail list logo
