[clang] [X86] Add ABI handling for __float128 (PR #75156)

https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/75156 >From 9860e5454bdf3ee3a4283ab7102a8d70c3ebcbbc Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Tue, 12 Dec 2023 17:27:33 +0800 Subject: [PATCH 1/5] [X86] Add ABI handling for fp128 Fixes #74601 --- clang/li

[clang] [X86] Add ABI handling for __float128 (PR #75156)

https://github.com/RKSimon approved this pull request. LGTM - please mention in the commit message + release notes that this matches GCC behaviour https://github.com/llvm/llvm-project/pull/75156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [X86] Add ABI handling for __float128 (PR #75156)

phoebewang wrote: > Add a Release notes entry? I always forget exactly what we need to do for ABI > fixes/tweaks Goot point! Done. https://github.com/llvm/llvm-project/pull/75156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [X86] Add ABI handling for __float128 (PR #75156)

https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/75156 >From 9860e5454bdf3ee3a4283ab7102a8d70c3ebcbbc Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Tue, 12 Dec 2023 17:27:33 +0800 Subject: [PATCH 1/4] [X86] Add ABI handling for fp128 Fixes #74601 --- clang/li

[clang] [X86] Add ABI handling for __float128 (PR #75156)

https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/75156 >From 9860e5454bdf3ee3a4283ab7102a8d70c3ebcbbc Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Tue, 12 Dec 2023 17:27:33 +0800 Subject: [PATCH 1/3] [X86] Add ABI handling for fp128 Fixes #74601 --- clang/li

[clang] [X86] Add ABI handling for __float128 (PR #75156)

RKSimon wrote: Add a Release notes entry? I always forget exactly what we need to do for ABI fixes/tweaks https://github.com/llvm/llvm-project/pull/75156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [X86] Add ABI handling for __float128 (PR #75156)

phoebewang wrote: Ping @RKSimon https://github.com/llvm/llvm-project/pull/75156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Add ABI handling for __float128 (PR #75156)

@@ -0,0 +1,35 @@ +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -target-feature +sse2 < %s | FileCheck %s --check-prefixes=CHECK phoebewang wrote: Yes, e.g, `llvm/test/CodeGen/X86/{soft-fp,x87}.ll`, though I doubt if they can work in reality since they ar

[clang] [X86] Add ABI handling for __float128 (PR #75156)

@@ -0,0 +1,35 @@ +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -target-feature +sse2 < %s | FileCheck %s --check-prefixes=CHECK RKSimon wrote: OK - so we have test coverage for non-SSE cases already in the backend? https://github.com/llvm/llvm-project/pu

[clang] [X86] Add ABI handling for __float128 (PR #75156)

@@ -0,0 +1,35 @@ +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -target-feature +sse2 < %s | FileCheck %s --check-prefixes=CHECK phoebewang wrote: I decided not to report error for `-sse` after investigating the current diagnosis machinism. We didn't repo

[clang] [X86] Add ABI handling for __float128 (PR #75156)

https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/75156 >From 9860e5454bdf3ee3a4283ab7102a8d70c3ebcbbc Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Tue, 12 Dec 2023 17:27:33 +0800 Subject: [PATCH 1/2] [X86] Add ABI handling for fp128 Fixes #74601 --- clang/li

[clang] [X86] Add ABI handling for __float128 (PR #75156)

@@ -0,0 +1,35 @@ +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -target-feature +sse2 < %s | FileCheck %s --check-prefixes=CHECK RKSimon wrote: If you're dealing with it soon then handling it in a followup sounds good to me https://github.com/llvm/llvm-pr

[clang] [X86] Add ABI handling for __float128 (PR #75156)

@@ -0,0 +1,35 @@ +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -target-feature +sse2 < %s | FileCheck %s --check-prefixes=CHECK phoebewang wrote: This patch only changes for 64-bit ABI, non-SSE is not a valid case for 64-bit. OTOH, -sse just generate iden

[clang] [X86] Add ABI handling for __float128 (PR #75156)

@@ -0,0 +1,35 @@ +// RUN: %clang_cc1 -triple x86_64-linux -emit-llvm -target-feature +sse2 < %s | FileCheck %s --check-prefixes=CHECK RKSimon wrote: Worth adding a non-SSE RUN? https://github.com/llvm/llvm-project/pull/75156 ___

[clang] [X86] Add ABI handling for __float128 (PR #75156)

https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/75156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits