https://github.com/aheejin closed
https://github.com/llvm/llvm-project/pull/122466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/122466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -120,26 +120,33 @@
// RUN: | FileCheck -check-prefix=EMSCRIPTEN_EH_ALLOWED_WO_ENABLE %s
// EMSCRIPTEN_EH_ALLOWED_WO_ENABLE: invalid argument '-mllvm
-emscripten-cxx-exceptions-allowed' only allowed with '-mllvm
-enable-emscripten-cxx-exceptions'
-// '-fwasm-exceptions'
@@ -413,53 +422,11 @@ void WebAssembly::addClangTargetOptions(const ArgList
&DriverArgs,
}
}
-if (Opt.starts_with("-wasm-enable-sjlj")) {
- // '-mllvm -wasm-enable-sjlj' is not compatible with
- // '-mno-exception-handling'
- if (DriverArgs.hasFla
@@ -120,26 +120,33 @@
// RUN: | FileCheck -check-prefix=EMSCRIPTEN_EH_ALLOWED_WO_ENABLE %s
// EMSCRIPTEN_EH_ALLOWED_WO_ENABLE: invalid argument '-mllvm
-emscripten-cxx-exceptions-allowed' only allowed with '-mllvm
-enable-emscripten-cxx-exceptions'
-// '-fwasm-exceptions'
@@ -154,46 +161,46 @@
// WASM_EXCEPTIONS_NO_REFERENCE_TYPES: invalid argument '-fwasm-exceptions'
not allowed with '-mno-reference-types'
// '-mllvm -wasm-enable-sjlj' sets +exception-handling, +multivalue,
-// +reference-types and '-exception-model=wasm'
+// +reference-type
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Heejin Ahn (aheejin)
Changes
There were many overlaps between error checking and feature enabling routines
for Wasm EH and Wasm SjLj. This tries to factor out those common routines in
separate lambda functions.
This is not NFC because th
https://github.com/aheejin created
https://github.com/llvm/llvm-project/pull/122466
There were many overlaps between error checking and feature enabling routines
for Wasm EH and Wasm SjLj. This tries to factor out those common routines in
separate lambda functions.
This is not NFC because thi
