https://github.com/4vtomat closed
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat resolved
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat updated
https://github.com/llvm/llvm-project/pull/66330
>From 8eb805beb037ba824fdf01dd8528b797a80de7ad Mon Sep 17 00:00:00 2001
From: 4vtomat
Date: Wed, 13 Sep 2023 22:59:30 -0700
Subject: [PATCH 1/3] [RISCV] Install sifive_vector.h to riscv-resource-headers
---
cla
https://github.com/4vtomat edited
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -623,6 +623,11 @@ install(
EXCLUDE_FROM_ALL
COMPONENT riscv-resource-headers)
+install(
4vtomat wrote:
Yes, we are missing from add_header_target("riscv-resource-headers"
"${riscv_files};${riscv_generated_files}").
I think we can just put sifive_vecto
@@ -623,6 +623,11 @@ install(
EXCLUDE_FROM_ALL
COMPONENT riscv-resource-headers)
+install(
topperc wrote:
Aren't we also missing `sifive_files` from
`add_header_target("riscv-resource-headers"
"${riscv_files};${riscv_generated_files}")`?
Is there any r
https://github.com/eopXD approved this pull request.
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/eopXD resolved
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s
+// REQUIRES: riscv-registered-target
+
+// expected-no-diagnostics
+
+#include
eopXD wrote:
I think we can't :(
https://github.com/llvm/llvm-project/pull/66330
__
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s
+// REQUIRES: riscv-registered-target
+
+// expected-no-diagnostics
+
+#include
4vtomat wrote:
Lit test is run before install, how can we check it's properly installed?
https://github.com
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s
+// REQUIRES: riscv-registered-target
+
+// expected-no-diagnostics
+
+#include
eopXD wrote:
Does this test case help verify we have `sifive_vector.h` installed?
https://github.com/llvm/l
https://github.com/eopXD edited https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat updated
https://github.com/llvm/llvm-project/pull/66330:
>From 8eb805beb037ba824fdf01dd8528b797a80de7ad Mon Sep 17 00:00:00 2001
From: 4vtomat
Date: Wed, 13 Sep 2023 22:59:30 -0700
Subject: [PATCH 1/2] [RISCV] Install sifive_vector.h to riscv-resource-headers
---
cl
eopXD wrote:
> > Maybe test coverage with `-I %resource_dir`?
>
> Which file should I place the test?
`clang/test/Headers/`
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
eopXD wrote:
Maybe test coverage?
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Changes
None
--
Full diff: https://github.com/llvm/llvm-project/pull/66330.diff
1 Files Affected:
- (modified) clang/lib/Headers/CMakeLists.txt (+5)
diff --git a/clang/lib/Headers/CMakeLists.txt b/clang/lib/Headers/CMakeLists.
https://github.com/4vtomat labeled
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat unlabeled
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat created
https://github.com/llvm/llvm-project/pull/66330:
None
>From 8eb805beb037ba824fdf01dd8528b797a80de7ad Mon Sep 17 00:00:00 2001
From: 4vtomat
Date: Wed, 13 Sep 2023 22:59:30 -0700
Subject: [PATCH] [RISCV] Install sifive_vector.h to riscv-resource-headers
---
https://github.com/4vtomat review_requested
https://github.com/llvm/llvm-project/pull/66330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
25 matches
Mail list logo
