[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/80760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/80760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

MaskRay wrote: I share a similar concern about not addressing the issue in a target-specific manner. However, I know a lot of confused users by the behavior, and this patch will significantly improve the status quo. I concur with asb's analysis. https://github.com/llvm/llvm-project/pull/80760

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

jrtc27 wrote: That's fair. I just imagine this is going to result in people forgetting about the underlying issue and adding their own patchwork fixes to work around it in their targets, so it would be a nice motivation to fix it properly. https://github.com/llvm/llvm-project/pull/80760 __

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

preames wrote: I agree with @asb's framing above. Assuming this doesn't commit us to something which is hard to forward version for some reason, I support addressing this in a target specific manner for the moment. https://github.com/llvm/llvm-project/pull/80760 _

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/80760 >From 8000459a247317400eda6213a23f32ac89e1ea75 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Mon, 5 Feb 2024 14:57:17 -0800 Subject: [PATCH 1/3] [RISCV] Add -march string as Module metadata in IR. In an LTO

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

zakk0610 wrote: Does the name of "riscv-arch" give the impression that it might be "march" string? https://github.com/llvm/llvm-project/pull/80760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

jrtc27 wrote: > > I just noticed we only set EF_RISCV_RVC based on C, and not Zca. Is that a > > bug? > > I think so; binutils sets it for both. (R_RISCV_ALIGN can probably fail if you don't, I don't think it's just a missing optimisation) https://github.com/llvm/llvm-project/pull/80760

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

jrtc27 wrote: > I just noticed we only set EF_RISCV_RVC based on C, and not Zca. Is that a > bug? I think so; binutils sets it for both. https://github.com/llvm/llvm-project/pull/80760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/80760 >From 8000459a247317400eda6213a23f32ac89e1ea75 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Mon, 5 Feb 2024 14:57:17 -0800 Subject: [PATCH 1/2] [RISCV] Add -march string as Module metadata in IR. In an LTO

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

topperc wrote: > * Just to check my understanding, is the only usecase for this ISA naming > string to produce appropriate ELF attributes? We probably need it to set the `EF_RISCV_RVC` flag too. I just noticed we only set EF_RISCV_RVC based on C, and not Zca. Is that a bug? https://github.com

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/80760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits