[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/BeMg closed https://github.com/llvm/llvm-project/pull/112161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/112161 >From d7a00a878b472e1ba7abad1b915cb57c4b0a5ca3 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 6 Oct 2024 22:19:07 -0700 Subject: [PATCH 1/5] [RISCV][FMV] Remove support for negative priority --- clang/lib/Co

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/112161 >From d7a00a878b472e1ba7abad1b915cb57c4b0a5ca3 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 6 Oct 2024 22:19:07 -0700 Subject: [PATCH 1/4] [RISCV][FMV] Remove support for negative priority --- clang/lib/Co

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

@@ -2909,18 +2909,16 @@ static int getPriorityFromAttrString(StringRef AttrStr) { AttrStr.split(Attrs, ';'); BeMg wrote: Sure. https://github.com/llvm/llvm-project/pull/112161 ___ cfe-commits mailing list cfe-commi

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

@@ -2909,18 +2909,16 @@ static int getPriorityFromAttrString(StringRef AttrStr) { AttrStr.split(Attrs, ';'); topperc wrote: Should the function return `unsigned` instead of `int` now? https://github.com/llvm/llvm-project/pull/112161 _

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/112161 >From d7a00a878b472e1ba7abad1b915cb57c4b0a5ca3 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 6 Oct 2024 22:19:07 -0700 Subject: [PATCH 1/2] [RISCV][FMV] Remove support for negative priority --- clang/lib/Co

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

@@ -3073,7 +3073,7 @@ bool Sema::checkTargetVersionAttr(SourceLocation LiteralLoc, Decl *D, DuplicateAttr = true; HasPriority = true; int Digit; -if (AttrStr.getAsInteger(0, Digit)) +if (AttrStr.getAsInteger(0, Digit) || Digit < 0) ---

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/topperc deleted https://github.com/llvm/llvm-project/pull/112161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

@@ -3073,7 +3073,7 @@ bool Sema::checkTargetVersionAttr(SourceLocation LiteralLoc, Decl *D, DuplicateAttr = true; HasPriority = true; int Digit; -if (AttrStr.getAsInteger(0, Digit)) +if (AttrStr.getAsInteger(0, Digit) || Digit < 0) ---

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/BeMg edited https://github.com/llvm/llvm-project/pull/112161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

@@ -111,3 +111,9 @@ __attribute__((target_version("default"))) int invalidVerson4(void) { return 2; __attribute__((target_version("priority=1"))) int prioriyWithoutArch(void) { return 2; } // expected-error@+1 {{redefinition of 'prioriyWithoutArch'}} __attribute__((target_ver

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Piyou Chen (BeMg) Changes Ensure that target_version and target_clones do not accept negative numbers for the priority feature. Base on discussion on https://github.com/riscv-non-isa/riscv-c-api-doc/pull/85. --- Patch is 23.87 KiB, tru

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang-codegen Author: Piyou Chen (BeMg) Changes Ensure that target_version and target_clones do not accept negative numbers for the priority feature. Base on discussion on https://github.com/riscv-non-isa/riscv-c-ap

[clang] [RISCV][FMV] Remove support for negative priority (PR #112161)

https://github.com/BeMg created https://github.com/llvm/llvm-project/pull/112161 Ensure that target_version and target_clones do not accept negative numbers for the priority feature. Base on discussion on https://github.com/riscv-non-isa/riscv-c-api-doc/pull/85. >From d7a00a878b472e1ba7abad1b