[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-11 Thread Ben Barham via cfe-commits
https://github.com/bnbarham closed https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-08 Thread Ben Barham via cfe-commits
bnbarham wrote: > LGTM! Maybe we can cherry pick it for the patch release 17.0.1. If that’s a > critical patch for swift we can try for the 17.0.0 release. It's in the appropriate branches in our fork, so it's fine for us either way. I suggested it more because of https://github.com/llvm/llvm-

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-08 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM! Maybe we can cherry pick it for the patch release 17.0.1. If that’s a critical patch for swift we can try for the 17.0.0 release. https://github.com/llvm/llvm-project/pull/65683 ___ cfe-

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-08 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread via cfe-commits
https://github.com/cor3ntin commented: Give a few days for other people to look at it, otherwise LGTM https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
bnbarham wrote: Seems Swift wasn't the only project to run into this, eg. https://github.com/llvm/llvm-project/issues/62413#issuecomment-1526499543. https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham created https://github.com/llvm/llvm-project/pull/65683: The preprocessor `IncrementalProcessing` option was being used to control whether or not to teardown the lexer or run the end of translation unit action. In D127284 this was merged with `-fincremental-extensio

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits