https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/116496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM! I believe the intent after d076608d58d1ec55016eb747a995511e3a3f72aa was
that consumers would eventually be updated to refer to the header in `Basic`
rather than in `Parse`, this just completes that.
https://github.com/llvm/llvm-
kazutakahirata wrote:
> Can you explain what is the perceived benefit of this change? Thanks
Sure.
- We'll have less code.
- We'll have fewer "false positives" from clangd's "unused include" warnings.
The .cpp files are not using anything declared in `ParseDiagnostic.h` because,
after all, `
cor3ntin wrote:
Can you explain what is the perceived benefit of this change? Thanks
https://github.com/llvm/llvm-project/pull/116496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Kazu Hirata (kazutakahirata)
Changes
This patch removes clang/Parse/ParseDiagnostic.h because it just
forwards to clang/Basic/DiagnosticParse.h.
---
Full diff: https://github.com/llvm/llvm-project/pull/116496.diff
17 Files Affected:
- (
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/116496
This patch removes clang/Parse/ParseDiagnostic.h because it just
forwards to clang/Basic/DiagnosticParse.h.
>From 62d97fa37e10f478cb02651abb38dde9d03da76d Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date
