[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-18 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: You can try to run preprocessor and then manually reduce the expanded code after preprocessor https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-18 Thread Akash Banerjee via cfe-commits
TIFitis wrote: @alexey-bataev I'm facing issues adding the test to Clang tests as it uses the complex.h header files. From what I can tell header files don't seem to be supported. Is there any way to add the test you provided to the Clang tests or a different one which can still check for the

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-05 Thread Akash Banerjee via cfe-commits
TIFitis wrote: Thanks @alexey-bataev for the test. It does hit the complex scenario. I'll close this PR and add that test in another PR. https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-05 Thread Akash Banerjee via cfe-commits
https://github.com/TIFitis closed https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-04 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > @alexey-bataev do you have any concerns about removing this case? I think better to add a test for complex reductions rather than removing its support. This simple test fails without complex supports. ``` #include int foo() { int i; int j; complex float sum; #pr

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-04 Thread Jan Leyonberg via cfe-commits
jsjodin wrote: @alexey-bataev do you have any concerns about removing this case? https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-02-26 Thread Akash Banerjee via cfe-commits
TIFitis wrote: Ping for review. https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-02-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akash Banerjee (TIFitis) Changes This patch removes the complex reduction variables codegen. There are currently no tests for this, and from playing around with some complex reduction variable test cases the code seems unreachable. The P

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-02-21 Thread Akash Banerjee via cfe-commits
https://github.com/TIFitis created https://github.com/llvm/llvm-project/pull/82497 This patch removes the complex reduction variables codegen. There are currently no tests for this, and from playing around with some complex reduction variable test cases the code seems unreachable. The PR #803