https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/129118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jplehr approved this pull request.
With the explanation that change seems reasonable. Thank you.
https://github.com/llvm/llvm-project/pull/129118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
jhuber6 wrote:
> > I think people are just confusing what `-flto` means when put on a link job.
>
> Including me. :)
>
> Apologies for my ignorance, what does this do and why do we want it? It
> allows for some (LTO-related?) flags to be forwarded/handled correctly?
The clang driver is very c
jplehr wrote:
> I think people are just confusing what `-flto` means when put on a link job.
Including me. :)
Apologies for my ignorance, what does this do and why do we want it?
It allows for some (LTO-related?) flags to be forwarded/handled correctly?
https://github.com/llvm/llvm-project/pul
jhuber6 wrote:
> > but it turns on LTO by default right?
>
> This is very much how I read that patch too. Maybe the flag names and
> comments are a bit misleading here.
I think people are just confusing what `-flto` means when put on a link job.
https://github.com/llvm/llvm-project/pull/12911
jplehr wrote:
> but it turns on LTO by default right?
This is very much how I read that patch too.
Maybe the flag names and comments are a bit misleading here.
https://github.com/llvm/llvm-project/pull/129118
___
cfe-commits mailing list
cfe-commits@l
jhuber6 wrote:
> We do have some framework teams that are still using non-LTO (or non-gpu-rdc)
> build.
This doesn't force that, adding `-flto` just informs the compiler to forward
certain flags to the linker.
https://github.com/llvm/llvm-project/pull/129118
__
shiltian wrote:
We do have some framework teams that are still using non-LTO (or non-gpu-rdc)
build.
https://github.com/llvm/llvm-project/pull/129118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Joseph Huber (jhuber6)
Changes
Summary:
Previously we turned this off, but that led to a regression in some of
the option handling. I would argue that handling LTO by default was
incorrect bheavior, but for AMDGPU people were used to this d
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/129118
Summary:
Previously we turned this off, but that led to a regression in some of
the option handling. I would argue that handling LTO by default was
incorrect bheavior, but for AMDGPU people were used to this defa
10 matches
Mail list logo