[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread Thurston Dang via cfe-commits
thurstond wrote: > > Would be possible to switch DiagnosedAlwaysRecoverableKinds to this > > function? > > That's a bit more complicated because it has Unrecoverable and > AlwaysRecoverable error cases (vs. the current function only has one error > case: ~Supported). I'll refactor Recoverable

[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread Thurston Dang via cfe-commits
https://github.com/thurstond closed https://github.com/llvm/llvm-project/pull/119797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread Thurston Dang via cfe-commits
thurstond wrote: > Would be possible to switch DiagnosedAlwaysRecoverableKinds to this function? That's a bit more complicated because it has Unrecoverable and AlwaysRecoverable error cases (vs. the current function only has one error case: ~Supported). I'll refactor RecoverableKinds in a foll

[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/119797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Would be possible to switch DiagnosedAlwaysRecoverableKinds to this function? https://github.com/llvm/llvm-project/pull/119797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Thurston Dang (thurstond) Changes parseSanitizeTrapArgs follows the general pattern of "compute the sanitizer mask based on the default plus opt-in (if supported) minus opt-out". This patch refactors the functionality into a genera

[clang] [NFCI][sanitizer] Refactor parseSanitizeTrapArgs (PR #119797)

2024-12-12 Thread Thurston Dang via cfe-commits
https://github.com/thurstond created https://github.com/llvm/llvm-project/pull/119797 parseSanitizeTrapArgs follows the general pattern of "compute the sanitizer mask based on the default plus opt-in (if supported) minus opt-out". This patch refactors the functionality into a generalized funct