https://github.com/dwblaikie approved this pull request.
https://github.com/llvm/llvm-project/pull/119445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joaosaffran wrote:
@llvm-beanz @dwblaikie I've built a bootstrap version of clang with and without
this change, the binary output was identical for both builds (check them with
`diff`), please let me know if there is something else you might need me testing
https://github.com/llvm/llvm-project
bogner wrote:
> Don't see a problem with this but could we elaborate on the motivation for
> this? Looks like this is required for #119041? Why is that?
>
> The original change this is based on is:
> [microsoft/DirectXShaderCompiler#6296](https://github.com/microsoft/DirectXShaderCompiler/pull
joaosaffran wrote:
@Michael137, currently we have this issue open:
https://github.com/llvm/llvm-project/issues/118523, after some investigation,
we figured that such was the same issue we have faced here
https://github.com/microsoft/DirectXShaderCompiler/pull/6296, the fix we did
there is the
Michael137 wrote:
Don't see a problem with this but could we elaborate on the motivation for
this? Looks like this is required for
https://github.com/llvm/llvm-project/pull/119041? Why is that?
The original change this is based on is:
https://github.com/microsoft/DirectXShaderCompiler/pull/62
joaosaffran wrote:
FYI: been working on the bootstrap build as well, those have been a bit slow on
my setup
https://github.com/llvm/llvm-project/pull/119445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
llvm-beanz wrote:
> any chance you could A/B test this on a bootstrap of clang, for instance? To
> help validate that this really is NFC/dead code?
I did a little more archeology, and I'm actually struggling to find any point
in the history where this change was required. The difference betwee
dwblaikie wrote:
any chance you could A/B test this on a bootstrap of clang, for instance? To
help validate that this really is NFC/dead code?
https://github.com/llvm/llvm-project/pull/119445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (joaosaffran)
Changes
This is PR is updating the debug info generation for `this`. This is required
to fix the generation of debug information for HLSL RWBuffer type. This was
required from another PR: https://github.com/llvm
https://github.com/joaosaffran created
https://github.com/llvm/llvm-project/pull/119445
This is PR is updating the debug info generation for `this`. This is required
to fix the generation of debug information for HLSL RWBuffer type. This was
required from another PR: https://github.com/llvm/ll
10 matches
Mail list logo
