[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/100753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/100753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/100753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/100753 >From 3cc18ded835f3a25dc98bc81988d3a2f1181c300 Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Sun, 5 May 2024 12:36:53 -0700 Subject: [PATCH 1/2] Reduce size of FunctionEffect to 1 byte. --- clang/include/c

[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread via cfe-commits
@@ -4699,16 +4699,16 @@ class FunctionEffect { private: LLVM_PREFERRED_TYPE(Kind) - unsigned FKind : 3; + uint8_t FKind : 3; Sirraide wrote: I mean, if this is the only field, then can’t we just make the actual type of this `Kind` since that’s a `uint8_t

[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Wyatt (dougsonos) Changes As a preliminary to PR https://github.com/llvm/llvm-project/pull/99656 , reduce the size of `FunctionEffect` to 1 byte. --- Full diff: https://github.com/llvm/llvm-project/pull/100753.diff 1 Files Affected

[clang] [NFC] Reduce size of FunctionEffect to 1 byte. (PR #100753)

2024-07-26 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos created https://github.com/llvm/llvm-project/pull/100753 As a preliminary to PR https://github.com/llvm/llvm-project/pull/99656 , reduce the size of `FunctionEffect` to 1 byte. >From 3cc18ded835f3a25dc98bc81988d3a2f1181c300 Mon Sep 17 00:00:00 2001 From: Doug Wyatt