https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115962
>From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:51:54 -0800
Subject: [PATCH 1/2] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName`
Simp
@@ -1786,33 +1786,17 @@ void clang::EmitClangDiagGroups(const RecordKeeper
&Records, raw_ostream &OS) {
// Diagnostic name index generation
//===--===//
-namespace {
-struct RecordIndexElement
-{
- RecordIn
https://github.com/kazutakahirata edited
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata approved this pull request.
LGTM modulo a minor comment. Thank you for cleaning this up!
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115962
Simplify `EmitClangDiagsIndexName` to directly sort records instead of creating
an array of `RecordIndexElement` containing record name and sorting it.
>From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17
