[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, bwendling wrote: I added more context to the commit m

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, nickdesaulniers wrote: Ah! Ok, they *why* for this PR

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, bwendling wrote: Yes, in particular I want to call it

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
bwendling wrote: > I'm assuming there are other targets that would benefit from being converted > as well? Not asking you to do it, just wondering what the best way to get it > done is. Yeah, the other platforms can implement this when / if they need it. It's really just a convenience functio

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/3] [NFC][CodeGen] Create method to clear registers Place the

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/2] [NFC][CodeGen] Create method to clear registers Place the