[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: The fix will need to be backported, but I don't think this fixed it all the way so we'll need another follow-up. https://github.com/llvm/llvm-project/pull/127528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread Matt Arsenault via cfe-commits
arsenm wrote: Missing test for the case where this broke? https://github.com/llvm/llvm-project/pull/127528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm milestoned https://github.com/llvm/llvm-project/pull/127528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/127528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Makes sense, since this is only for these call arguments which are handled in all cases now I presume. https://github.com/llvm/llvm-project/pull/127528 ___ cfe-commits mailing list cfe-commits@lis

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Alex Voicu (AlexVlx) Changes This removes a vestigial assertion, which would erroneously trigger even though we now correctly handle valid arg mismatches (

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Voicu (AlexVlx) Changes This removes a vestigial assertion, which would erroneously trigger even though we now correctly handle valid arg mismatches (

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

2025-02-17 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/127528 This removes a vestigial assertion, which would erroneously trigger even though we now correctly handle valid arg mismatches (