vhscampos wrote:
I've reverted this patch because apparently Clang driver does not meld well
with `std::shared_ptr`: memory leaks due to custom allocators I think. Thus
I've redone the part to use raw pointers instead:
https://github.com/llvm/llvm-project/pull/122903
https://github.com/llvm/l
https://github.com/vhscampos closed
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From 3914f0f5afbc8549dbc3557b70abb21f96be2db7 Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH 1/2] [Multilib] Custom flags YAML parsing
This patch adds supp
https://github.com/vhscampos edited
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From 4c9756a323f67dbe5fbdb45cf2ddb5f97adad18d Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH 1/2] [Multilib] Custom flags YAML parsing
This patch adds supp
https://github.com/vhscampos edited
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vhscampos edited
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From 4c9756a323f67dbe5fbdb45cf2ddb5f97adad18d Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH] [Multilib] Custom flags YAML parsing
This patch adds support
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From e194bdad39ea7f719e1a133eca94f9ce6ef3e881 Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH 1/3] [Multilib] Custom flags YAML parsing
This patch adds supp
vhscampos wrote:
Created PR to amend `Multilib.rst`:
https://github.com/llvm/llvm-project/pull/114998
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
vhscampos wrote:
Thanks @smithp35. Before any of the PRs is merged, I will update the
descriptions to make them more self-contained.
Furthermore, `Multilib.rst` must indeed be updated. Will do it.
https://github.com/llvm/llvm-project/pull/110657
___
smithp35 wrote:
> This patch adds support for custom flags in the multilib YAML file.
>
> Details about this change can be found in this thread:
> https://discourse.llvm.org/t/rfc-multilib-custom-flags/81058
Apologies in advance for being a pain. Prior to commit, assuming that the RFC
has sta
https://github.com/statham-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -259,11 +266,69 @@ template <> struct
llvm::yaml::MappingTraits {
}
};
+template <>
+struct llvm::yaml::MappingContextTraits> {
+ static void mapping(llvm::yaml::IO &io, custom_flag::CustomFlagValueDetail
&V,
+ llvm::SmallSet &) {
+io.mapRequir
@@ -101,6 +101,25 @@ class Multilib {
raw_ostream &operator<<(raw_ostream &OS, const Multilib &M);
+namespace custom_flag {
+struct CustomFlagDeclaration;
vhscampos wrote:
Fixed
https://github.com/llvm/llvm-project/pull/110657
__
@@ -101,6 +101,25 @@ class Multilib {
raw_ostream &operator<<(raw_ostream &OS, const Multilib &M);
+namespace custom_flag {
+struct CustomFlagDeclaration;
+using CustomFlagDeclarationPtr = std::shared_ptr;
+
+struct CustomFlagValueDetail {
+ std::string Name;
+ std::optiona
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From e194bdad39ea7f719e1a133eca94f9ce6ef3e881 Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH 1/2] [Multilib] Custom flags YAML parsing
This patch adds supp
@@ -259,11 +266,69 @@ template <> struct
llvm::yaml::MappingTraits {
}
};
+template <>
+struct llvm::yaml::MappingContextTraits> {
+ static void mapping(llvm::yaml::IO &io, custom_flag::CustomFlagValueDetail
&V,
+ llvm::SmallSet &) {
+io.mapRequir
@@ -101,6 +101,25 @@ class Multilib {
raw_ostream &operator<<(raw_ostream &OS, const Multilib &M);
+namespace custom_flag {
+struct CustomFlagDeclaration;
+using CustomFlagDeclarationPtr = std::shared_ptr;
+
+struct CustomFlagValueDetail {
+ std::string Name;
+ std::optiona
@@ -101,6 +101,25 @@ class Multilib {
raw_ostream &operator<<(raw_ostream &OS, const Multilib &M);
+namespace custom_flag {
+struct CustomFlagDeclaration;
statham-arm wrote:
Seems a bit verbose to me: all references to these types end up looking like
`custo
https://github.com/vhscampos ready_for_review
https://github.com/llvm/llvm-project/pull/110657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Victor Campos (vhscampos)
Changes
This patch adds support for custom flags in the multilib YAML file.
Details about this change can be found in this thread:
https://discourse.llvm.org/t/rfc-multilib-custom-flags/81058
---
Full diff: http
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/110657
>From e194bdad39ea7f719e1a133eca94f9ce6ef3e881 Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Thu, 26 Sep 2024 14:43:18 +0100
Subject: [PATCH] [Multilib] Custom flags YAML parsing
This patch adds support
24 matches
Mail list logo
