https://github.com/xu-chiheng closed
https://github.com/llvm/llvm-project/pull/74979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xu-chiheng wrote:
> > In Cygwin with binutils 2.41, --dynamicbase make a difference, so I thought
> > MinGW also need it.
>
> No, MinGW does not need it, as it has been enabled by default since binutils
> 2.36.
>
> Apparently that change,
> https://sourceware.org/git/?p=binutils-gdb.git;a=c
mstorsjo wrote:
> > Also
>
> In Cygwin with binutils 2.41, --dynamicbase make a difference, so I thought
> MinGW also need it.
No, MinGW does not need it, as it has been enabled by default since binutils
2.36.
Apparently that change,
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdi
xu-chiheng wrote:
> Also
In Cygwin with binutils 2.41, --dynamicbase make a difference, so I thought
MinGW also need it.
https://github.com/llvm/llvm-project/pull/74979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/mstorsjo requested changes to this pull request.
No, you do not need to do this. There's no need to add `--dynamicbase` manually
in Clang. As I already posted, both ld.bfd and ld.lld default to
`--dynamicbase` enabled since 2020.
https://github.com/llvm/llvm-project/pull/749
https://github.com/xu-chiheng updated
https://github.com/llvm/llvm-project/pull/74979
From e08d12df9f987ad4cf025d4bf1896acf2deea859 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?=
Date: Sun, 10 Dec 2023 15:03:28 +0800
Subject: [PATCH 1/2] 1
---
clang/lib
https://github.com/mstorsjo requested changes to this pull request.
This is not necessary.
Since 514b4e191d5f46de8e142fe216e677a35fa9c4bb in binutils
(https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=514b4e191d5f46de8e142fe216e677a35fa9c4bb),
dynamicbase is enabled by default. Als
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: 徐持恒 Xu Chiheng (xu-chiheng)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/74979.diff
1 Files Affected:
- (modified) clang/lib/Driver/ToolChains/MinGW.cpp (+1)
``diff
diff --git a/clang/lib/Driver/ToolChain
https://github.com/xu-chiheng created
https://github.com/llvm/llvm-project/pull/74979
None
From e08d12df9f987ad4cf025d4bf1896acf2deea859 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?=
Date: Sun, 10 Dec 2023 15:03:28 +0800
Subject: [PATCH] 1
---
clang/l
