[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/3768 Here is the relevan

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-16 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-16 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 722a446023bd394c85c6eebf66e7bb5631a92a4d Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] [MS] Add /Zc:tlsGuards option to control tls guard emission --- cl

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-13 Thread Maurice Heumann via cfe-commits
momo5502 wrote: > LGTM Thanks, would you mind merging it for me please https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-13 Thread Eli Friedman via cfe-commits
@@ -4063,6 +4063,11 @@ defm threadsafe_statics : BoolFOption<"threadsafe-statics", NegFlag, PosFlag>; +defm tls_guards : BoolFOption<"tls-guards", + LangOpts<"TlsGuards">, DefaultTrue, efriedma-quic wrote: My understanding is that if a tls variable is def

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-13 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-09 Thread Maurice Heumann via cfe-commits
momo5502 wrote: @efriedma-quic is the PR fine like that? https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-01 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 46aede6d9c19eeb304554ac3fdd0fe4b04b3e257 Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] [MS] Add /Zc:tlsGuards option to control tls guard emission --- cl

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-01 Thread Maurice Heumann via cfe-commits
@@ -4063,6 +4063,11 @@ defm threadsafe_statics : BoolFOption<"threadsafe-statics", NegFlag, PosFlag>; +defm tls_guards : BoolFOption<"tls-guards", + LangOpts<"TlsGuards">, DefaultTrue, momo5502 wrote: Ah I see :D i have never added an option before. I re

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-01 Thread Maurice Heumann via cfe-commits
@@ -186,6 +186,7 @@ COMPATIBLE_LANGOPT(RecoveryAST, 1, 1, "Preserve expressions in AST when encounte COMPATIBLE_LANGOPT(RecoveryASTType, 1, 1, "Preserve the type in recovery expressions") BENIGN_LANGOPT(ThreadsafeStatics , 1, 1, "thread-safe static initializers") +BENIGN_LAN

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-11-01 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 8caca3e5a7caeedd47f2910b82dcde2e7fbbcba7 Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] [MS] Add /Zc:tlsGuards option to control tls guard emission --- cl

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-30 Thread Eli Friedman via cfe-commits
@@ -186,6 +186,7 @@ COMPATIBLE_LANGOPT(RecoveryAST, 1, 1, "Preserve expressions in AST when encounte COMPATIBLE_LANGOPT(RecoveryASTType, 1, 1, "Preserve the type in recovery expressions") BENIGN_LANGOPT(ThreadsafeStatics , 1, 1, "thread-safe static initializers") +BENIGN_LAN

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-30 Thread Eli Friedman via cfe-commits
@@ -4063,6 +4063,11 @@ defm threadsafe_statics : BoolFOption<"threadsafe-statics", NegFlag, PosFlag>; +defm tls_guards : BoolFOption<"tls-guards", + LangOpts<"TlsGuards">, DefaultTrue, efriedma-quic wrote: If we're going to expose this as a clang option (

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-30 Thread Maurice Heumann via cfe-commits
momo5502 wrote: seems like nobody can review this. maybe you, @efriedma-quic, have time 😊 https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/113830 >From 23d4562382b753c604fffa078f8bdd0f75d57ac4 Mon Sep 17 00:00:00 2001 From: momo5502 Date: Sun, 27 Oct 2024 20:02:00 +0100 Subject: [PATCH] [MS] Add /Zc:tlsGuards option to control tls guard emission --- cl

[clang] [MS] Add /Zc:tlsGuards option to control tls guard emission (PR #113830)

2024-10-27 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 edited https://github.com/llvm/llvm-project/pull/113830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits