[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/130285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/130285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
@@ -599,9 +599,11 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
@@ -599,9 +599,11 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/130285 >From d39b407a6ae2000f91a345c18cb710647b86c1c8 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Mar 2025 07:54:50 -0600 Subject: [PATCH 1/3] [LinkerWrapper] Try to fix testing on Windows Summary: Thanks

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/130285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
@@ -599,9 +599,11 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur requested changes to this pull request. Not aware of any filename sanitizer utility either. https://github.com/llvm/llvm-project/pull/130285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
@@ -599,9 +599,10 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/130285 >From d39b407a6ae2000f91a345c18cb710647b86c1c8 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Mar 2025 07:54:50 -0600 Subject: [PATCH 1/2] [LinkerWrapper] Try to fix testing on Windows Summary: Thanks

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Matt Arsenault via cfe-commits
@@ -599,9 +599,10 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
@@ -599,9 +599,10 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/130285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Michael Kruse via cfe-commits
@@ -599,9 +599,10 @@ Expected writeOffloadFile(const OffloadFile &File) { StringRef Prefix = sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); - - auto TempFileOrErr = createOutputFile( - Prefix + "-" + Binary.getTriple() + "-" + Binary.getArch

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: Thanks to @Meinersbur for finding this. The `:` character used in AMD's target-id's is invalid on windows. This patch replaces them with `_`. --- Full diff: https://github.com/llvm/llvm-project/pull

[clang] [LinkerWrapper] Try to fix testing on Windows (PR #130285)

2025-03-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/130285 Summary: Thanks to @Meinersbur for finding this. The `:` character used in AMD's target-id's is invalid on windows. This patch replaces them with `_`. >From d39b407a6ae2000f91a345c18cb710647b86c1c8 Mon Sep 17 0