[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-10 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: This broke our flang-enabled buildbot https://lab.llvm.org/staging/#/builders/105/builds/15554 Looking at it currently https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126297 >From a19b3263a99c3def8ec4b756d8cf85233ebf9735 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Feb 2025 13:39:56 -0600 Subject: [PATCH 1/2] [LinkerWrapper] Clean up options after proper forwarding Summ

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9220,13 +9220,24 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, for (StringRef Arg : LinkerArgs) CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + + // Forward the LTO

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
@@ -9220,13 +9220,24 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, for (StringRef Arg : LinkerArgs) CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + + // Forward the LTO

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9220,13 +9220,24 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, for (StringRef Arg : LinkerArgs) CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + + // Forward the LTO

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9220,13 +9220,24 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, for (StringRef Arg : LinkerArgs) CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + + // Forward the LTO

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126297 >From a19b3263a99c3def8ec4b756d8cf85233ebf9735 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Feb 2025 13:39:56 -0600 Subject: [PATCH] [LinkerWrapper] Clean up options after proper forwarding Summary:

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126297 >From 5267aa9911ea8bdce217f7420e123b5976df3f5b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Feb 2025 13:39:56 -0600 Subject: [PATCH] [LinkerWrapper] Clean up options after proper forwarding Summary:

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9223,6 +9223,8 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("--host-triple=" + getToolChain().getTripleString())); if (Args.hasArg(options::OPT_v)) CmdArgs.push_back("--wrapper-verbose"); + if (Arg *A = Args.getLa

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
@@ -21,16 +21,16 @@ __attribute__((visibility("protected"), used)) int x; // RUN: clang-linker-wrapper --host-triple=x86_64-unknown-linux-gnu --dry-run \ // RUN: --linker-path=/usr/bin/ld %t.o -o a.out 2>&1 | FileCheck %s --check-prefix=NVPTX-LINK -// NVPTX-LINK: clang{{.*}

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
@@ -9223,6 +9223,8 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("--host-triple=" + getToolChain().getTripleString())); if (Args.hasArg(options::OPT_v)) CmdArgs.push_back("--wrapper-verbose"); + if (Arg *A = Args.getLa

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -21,16 +21,16 @@ __attribute__((visibility("protected"), used)) int x; // RUN: clang-linker-wrapper --host-triple=x86_64-unknown-linux-gnu --dry-run \ // RUN: --linker-path=/usr/bin/ld %t.o -o a.out 2>&1 | FileCheck %s --check-prefix=NVPTX-LINK -// NVPTX-LINK: clang{{.*}

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9223,6 +9223,8 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("--host-triple=" + getToolChain().getTripleString())); if (Args.hasArg(options::OPT_v)) CmdArgs.push_back("--wrapper-verbose"); + if (Arg *A = Args.getLa

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126297 >From f553b8a2d53f41690402f6a7f781b74c97fc81d4 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Feb 2025 13:39:56 -0600 Subject: [PATCH] [LinkerWrapper] Clean up options after proper forwarding Summary:

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d9500f5032312776c69e4bf41722d62ef9c76e49 1a6aa666e5ac32a559d0eb2e854d08f45695e6ac --e

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: Recent changes made a lot of this stuff redundant or unused, clean it up a bit. Also snuck in a change to pass the CUDA path since we still use it for `fatbinary` internally. --- Full diff: https:/

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/126297 Summary: Recent changes made a lot of this stuff redundant or unused, clean it up a bit. Also snuck in a change to pass the CUDA path since we still use it for `fatbinary` internally. >From 1a6aa666e5ac32a559d