llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `clang` at step 6
"test-build-unified-tree-check-clang".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/7827
Here is the re
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast`
running on `gribozavr4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/56/builds/7605
Here is the rele
thurstond wrote:
> Sorry I didn't mention here that the fix was in. It looks like everything is
> clean now?
Yes, both your changes are back in and I anticipate the buildbots will be green
again. Sorry for the noise!
https://github.com/llvm/llvm-project/pull/106588
___
pow2clk wrote:
Sorry I didn't mention here that the fix was in. It looks like everything is
clean now?
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
thurstond wrote:
I've reverted both of my reverts
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thurstond wrote:
Oh, actually, I just realized the test update was the fix-forward. So the
correct fix would be to reland both the change and the test update. Sorry!
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-com
thurstond wrote:
@nico Sorry, my bad. I didn't notice the test was also updated as a companion
to this change (https://github.com/llvm/llvm-project/pull/109023). I'll revert
the test as well.
https://github.com/llvm/llvm-project/pull/106588
___
cfe-c
nico wrote:
@thurstond ^
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Looks like the _revert_ broke check-clang:
http://45.33.8.238/linux/148045/step_6.txt
Please take a look, and uh, mark that test as UNSUPPORTED if it takes a while
to fix, I suppose.
https://github.com/llvm/llvm-project/pull/106588
___
c
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux`
running on `premerge-linux-1` while building `clang` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/153/builds/9181
Here is
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while
building `clang` at step 7 "test-build-stage1-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/168/bu
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/5917
Here is the
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/7235
https://github.com/pow2clk closed
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 01/12] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all it
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -emit-llvm-only %s
-verify
llvm-beanz wrote:
We should not need to emit IR to test a warning. This should work with
`-fsyntax-only` or without the `-emit-llvm-only` flag.
https://githu
@@ -2502,9 +2505,16 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
ShouldAddOptNone &= !D->hasAttr();
ShouldAddOptNone &= !D->hasAttr();
- // Add optnone, but do so only if the function isn't always_inline.
- if ((ShouldAddOptNone || D->has
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 01/11] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all it
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 01/10] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all it
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/9] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
@@ -2471,11 +2471,14 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
B.addAttribute(llvm::Attribute::StackProtectReq);
if (!D) {
+// HLSL functions must always be inlined
+if (getLangOpts().HLSL && !F->hasFnAttribute("hlsl.shader"))
https://github.com/damyanp approved this pull request.
LGTM, but would be good to get a review from someone more knowledgeable in the
area than I am.
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/8] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
@@ -2471,11 +2471,14 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
B.addAttribute(llvm::Attribute::StackProtectReq);
if (!D) {
+// HLSL functions must always be inlined
+if (getLangOpts().HLSL && !F->hasFnAttribute("hlsl.shader"))
@@ -2502,9 +2505,12 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
ShouldAddOptNone &= !D->hasAttr();
ShouldAddOptNone &= !D->hasAttr();
- // Add optnone, but do so only if the function isn't always_inline.
- if ((ShouldAddOptNone || D->has
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2471,11 +2471,14 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
B.addAttribute(llvm::Attribute::StackProtectReq);
if (!D) {
+// HLSL functions must always be inlined
llvm-beanz wrote:
nit: we do try have comments b
@@ -2471,11 +2471,14 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
B.addAttribute(llvm::Attribute::StackProtectReq);
if (!D) {
+// HLSL functions must always be inlined
+if (getLangOpts().HLSL && !F->hasFnAttribute("hlsl.shader"))
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/7] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/6] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
@@ -2474,7 +2474,9 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
// If we don't have a declaration to control inlining, the function isn't
// explicitly marked as alwaysinline for semantic reasons, and inlining is
// disabled, mark th
@@ -1239,9 +1239,9 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
if (getLangOpts().OpenMP && CurCodeDecl)
CGM.getOpenMPRuntime().emitFunctionProlog(*this, CurCodeDecl);
- if (FD && getLangOpts().HLSL) {
+ if (getLangOpts().HLSL) {
// Handl
@@ -0,0 +1,114 @@
+// RUN: %clang_cc1 -x hlsl -triple dxil-pc-shadermodel6.3-library %s
-emit-llvm -disable-llvm-passes -o - | FileCheck %s
--check-prefixes=CHECK,NOINLINE
+// RUN: %clang_cc1 -x hlsl -triple dxil-pc-shadermodel6.3-library %s
-emit-llvm -O0 -o - | FileCheck %s
https://github.com/pow2clk edited
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pow2clk commented:
Thanks Damyan!
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1239,9 +1239,9 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
if (getLangOpts().OpenMP && CurCodeDecl)
CGM.getOpenMPRuntime().emitFunctionProlog(*this, CurCodeDecl);
- if (FD && getLangOpts().HLSL) {
+ if (getLangOpts().HLSL) {
// Handl
@@ -2474,7 +2474,9 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
// If we don't have a declaration to control inlining, the function isn't
// explicitly marked as alwaysinline for semantic reasons, and inlining is
// disabled, mark th
@@ -0,0 +1,74 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -std=hlsl202x
-emit-llvm -o - -disable-llvm-passes %s | FileCheck %s
--check-prefixes=CHECK,NOINLINE
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -std=hlsl202x
-emit-llvm -o - -disable-llv
@@ -0,0 +1,114 @@
+// RUN: %clang_cc1 -x hlsl -triple dxil-pc-shadermodel6.3-library %s
-emit-llvm -disable-llvm-passes -o - | FileCheck %s
--check-prefixes=CHECK,NOINLINE
+// RUN: %clang_cc1 -x hlsl -triple dxil-pc-shadermodel6.3-library %s
-emit-llvm -O0 -o - | FileCheck %s
https://github.com/pow3clk edited
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ecd65e64e885b0fd2786ca99ea0c42d692275d91
fc22a5a9f2f9678393c563de87d8326112e5e0c9 --e
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/4] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/3] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
@@ -290,8 +290,6 @@ struct BuiltinTypeDeclBuilder {
SourceLocation()));
MethodDecl->setLexicalDeclContext(Record);
MethodDecl->setAccess(AccessSpecifier::AS_public);
-MethodDecl->addAttr(AlwaysInlineAttr::CreateImplicit(
https://github.com/pow3clk edited
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pow3clk commented:
On my laptop account. I assure you it's who you think it is.
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -414,9 +414,20 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl
*FD,
void CGHLSLRuntime::setHLSLFunctionAttributes(const FunctionDecl *FD,
llvm::Function *Fn) {
- if (FD->isInExportDeclContext()) {
-const String
@@ -290,8 +290,6 @@ struct BuiltinTypeDeclBuilder {
SourceLocation()));
MethodDecl->setLexicalDeclContext(Record);
MethodDecl->setAccess(AccessSpecifier::AS_public);
-MethodDecl->addAttr(AlwaysInlineAttr::CreateImplicit(
@@ -414,9 +414,20 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl
*FD,
void CGHLSLRuntime::setHLSLFunctionAttributes(const FunctionDecl *FD,
llvm::Function *Fn) {
- if (FD->isInExportDeclContext()) {
-const String
@@ -290,8 +290,6 @@ struct BuiltinTypeDeclBuilder {
SourceLocation()));
MethodDecl->setLexicalDeclContext(Record);
MethodDecl->setAccess(AccessSpecifier::AS_public);
-MethodDecl->addAttr(AlwaysInlineAttr::CreateImplicit(
@@ -414,9 +414,20 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl
*FD,
void CGHLSLRuntime::setHLSLFunctionAttributes(const FunctionDecl *FD,
llvm::Function *Fn) {
- if (FD->isInExportDeclContext()) {
-const String
@@ -290,8 +290,6 @@ struct BuiltinTypeDeclBuilder {
SourceLocation()));
MethodDecl->setLexicalDeclContext(Record);
MethodDecl->setAccess(AccessSpecifier::AS_public);
-MethodDecl->addAttr(AlwaysInlineAttr::CreateImplicit(
@@ -414,9 +414,20 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl
*FD,
void CGHLSLRuntime::setHLSLFunctionAttributes(const FunctionDecl *FD,
llvm::Function *Fn) {
- if (FD->isInExportDeclContext()) {
-const String
https://github.com/pow2clk updated
https://github.com/llvm/llvm-project/pull/106588
>From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001
From: Greg Roth
Date: Wed, 24 Jul 2024 16:49:19 -0600
Subject: [PATCH 1/2] [HLSL] set alwaysinline on HLSL functions
HLSL inlines all its
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Greg Roth (pow2clk)
Changes
HLSL inlines all its functions by default. This uses the alwaysinline attribute
to force that in the corresponding pass for user functions by default and
overrides the default noinline of some implicit
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Greg Roth (pow2clk)
Changes
HLSL inlines all its functions by default. This uses the alwaysinline attribute
to force that in the corresponding pass for user functions by default and
overrides the default noinline of some implicit functions
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Greg Roth (pow2clk)
Changes
HLSL inlines all its functions by default. This uses the alwaysinline attribute
to force that in the corresponding pass for user functions by default and
overrides the default noinline of some implicit function
https://github.com/pow2clk created
https://github.com/llvm/llvm-project/pull/106588
HLSL inlines all its functions by default. This uses the alwaysinline attribute
to force that in the corresponding pass for user functions by default and
overrides the default noinline of some implicit function
60 matches
Mail list logo
