https://github.com/spall closed https://github.com/llvm/llvm-project/pull/129773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -141,6 +141,8 @@ void Parser::ParseHLSLAnnotations(ParsedAttributes &Attrs,
return;
}
+ II = PP.getIdentifierInfo(II->getName().lower());
llvm-beanz wrote:
Can we keep the original identifier around and use that for the diagnostics so
that the diag
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/129773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-beanz wrote:
> > nit: is there a way to check that the spelling is consistent in the error
> > messages? Asking since I am no familiar with this part of the code.
>
> I'm not sure I understand what you mean.
I think the point (and my earlier comment) is to use the spelling as it is
writt
https://github.com/spall updated
https://github.com/llvm/llvm-project/pull/129773
>From 6c2e22d2fa59f34401156ac6fd85c44730bf8c45 Mon Sep 17 00:00:00 2001
From: Sarah Spall
Date: Tue, 4 Mar 2025 12:58:13 -0800
Subject: [PATCH 1/3] make semantics case insensitive. update tests. add new
tests
--
spall wrote:
> nit: is there a way to check that the spelling is consistent in the error
> messages? Asking since I am no familiar with this part of the code.
I'm not sure I understand what you mean.
https://github.com/llvm/llvm-project/pull/129773
_
https://github.com/joaosaffran commented:
nit: is there a way to check that the spelling is consistent in the error
messages? Asking since I am no familiar with this part of the code.
https://github.com/llvm/llvm-project/pull/129773
___
cfe-commits ma
@@ -4790,7 +4790,7 @@ def HLSLPackOffset: HLSLAnnotationAttr {
}
def HLSLSV_DispatchThreadID: HLSLAnnotationAttr {
- let Spellings = [HLSLAnnotation<"SV_DispatchThreadID">];
+ let Spellings = [HLSLAnnotation<"sv_dispatchthreadid">];
llvm-beanz wrote:
Can we
https://github.com/spall updated
https://github.com/llvm/llvm-project/pull/129773
>From 6c2e22d2fa59f34401156ac6fd85c44730bf8c45 Mon Sep 17 00:00:00 2001
From: Sarah Spall
Date: Tue, 4 Mar 2025 12:58:13 -0800
Subject: [PATCH 1/2] make semantics case insensitive. update tests. add new
tests
--
@@ -141,6 +141,8 @@ void Parser::ParseHLSLAnnotations(ParsedAttributes &Attrs,
return;
}
+ II = PP.getIdentifierInfo(II->getName().lower());
spall wrote:
Okay that might requirement a significant change. I'll look into it
https://github.com/llvm/llvm
10 matches
Mail list logo
