https://github.com/hekota closed
https://github.com/llvm/llvm-project/pull/107299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/107299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -834,17 +834,10 @@ static void ValidateMultipleRegisterAnnotations(Sema &S,
Decl *TheDecl,
static void DiagnoseHLSLRegisterAttribute(Sema &S, SourceLocation &ArgLoc,
Decl *TheDecl, RegisterType regType)
{
- // Samplers, UAVs, and
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/107299
>From 038e47d8ec75c03b895eb8bb5540f1fee9f4b936 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Wed, 4 Sep 2024 12:55:43 -0700
Subject: [PATCH 1/2] [HLSL] Remove variables used only in assert
---
clang/lib/Sem
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/107299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -834,17 +834,10 @@ static void ValidateMultipleRegisterAnnotations(Sema &S,
Decl *TheDecl,
static void DiagnoseHLSLRegisterAttribute(Sema &S, SourceLocation &ArgLoc,
Decl *TheDecl, RegisterType regType)
{
- // Samplers, UAVs, and
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Helena Kotas (hekota)
Changes
Changes the assert to test the same condition without using the variables.
This change is done in response to a comment
[here](https://github.com/llvm/llvm-project/pull/106657#issuecomment-2327493439).
---
https://github.com/hekota created
https://github.com/llvm/llvm-project/pull/107299
Changes the assert to test the same condition without using the variables.
This change is done in response to a comment
[here](https://github.com/llvm/llvm-project/pull/106657#issuecomment-2327493439).
>From
