[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall updated https://github.com/llvm/llvm-project/pull/131666 >From 4d4541232fb8ada1a4a17701919809a2a727d52d Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Mon, 17 Mar 2025 12:01:11 -0700 Subject: [PATCH 1/2] remove Macros implementing overloads for min and max. Implement

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall edited https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall closed https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall updated https://github.com/llvm/llvm-project/pull/131666 >From 4d4541232fb8ada1a4a17701919809a2a727d52d Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Mon, 17 Mar 2025 12:01:11 -0700 Subject: [PATCH 1/5] remove Macros implementing overloads for min and max. Implement

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall updated https://github.com/llvm/llvm-project/pull/131666 >From 4d4541232fb8ada1a4a17701919809a2a727d52d Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Mon, 17 Mar 2025 12:01:11 -0700 Subject: [PATCH 1/4] remove Macros implementing overloads for min and max. Implement

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall updated https://github.com/llvm/llvm-project/pull/131666 >From 4d4541232fb8ada1a4a17701919809a2a727d52d Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Mon, 17 Mar 2025 12:01:11 -0700 Subject: [PATCH 1/3] remove Macros implementing overloads for min and max. Implement

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall edited https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

@@ -54,5 +54,67 @@ clamp(U p0, V p1, W p2) { return clamp(p0, (U)p1, (U)p2); } +//===--===// +// max builtin overloads +//===--===// + +tem

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Sarah Spall (spall) Changes Replace min and max overload implementation using macros with one using templates. Enable new overloads of the forms: vector min/max(vector p0, U p1) vector min/max(U p0, vector p1) vector

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

@@ -54,5 +54,67 @@ clamp(U p0, V p1, W p2) { return clamp(p0, (U)p1, (U)p2); } +//===--===// +// max builtin overloads +//===--===// + +tem

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

spall wrote: > LGTM! Unfortunate about the macros not working out but this alternative is > pretty convenient. They would have worked if we didn't need even more overloads! https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/bob80905 approved this pull request. LGTM! Unfortunate about the macros not working out but this alternative is pretty convenient. https://github.com/llvm/llvm-project/pull/131666 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-backend-x86 Author: Sarah Spall (spall) Changes Replace min and max overload implementation using macros with one using templates. Enable new overloads of the forms: vector min/max(vector p0, U p1) vector min/m

[clang] [HLSL] Implement min and max overloads using templates (PR #131666)

https://github.com/spall created https://github.com/llvm/llvm-project/pull/131666 Replace min and max overload implementation using macros with one using templates. Enable new overloads of the forms: vector min/max(vector p0, U p1) vector min/max(U p0, vector p1) vector min/max(vector p0, ve