https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/112757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Keenuts approved this pull request.
https://github.com/llvm/llvm-project/pull/112757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From f113230de7412cc2440a800be6d3d3640742adbe Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/2] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/2] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/6] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
@@ -469,14 +479,22 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
for (auto &F : M.functions()) {
if (!F.hasFnAttribute("hlsl.shader"))
continue;
-IRBuilder<> B(&F.getEntryBlock(), F.getEntryBlock().begin());
+auto *Token = getConvergenceToken(F.getE
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -triple spirv-pc-vulkan-compute -finclude-default-header
-fnative-half-type -disable-llvm-passes -emit-llvm -o - %s | FileCheck %s
s-perron wrote:
I copied from another test. I have removed it.
https://github.com/llvm/llvm-p
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/112757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -triple spirv-pc-vulkan-compute -finclude-default-header
-fnative-half-type -disable-llvm-passes -emit-llvm -o - %s | FileCheck %s
farzonl wrote:
This test doesn't do anything with `native half types why do you need the
`-fn
https://github.com/farzonl approved this pull request.
Code looks correct. Issues found were minor so LGTM.
https://github.com/llvm/llvm-project/pull/112757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -469,14 +479,22 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
for (auto &F : M.functions()) {
if (!F.hasFnAttribute("hlsl.shader"))
continue;
-IRBuilder<> B(&F.getEntryBlock(), F.getEntryBlock().begin());
+auto *Token = getConvergenceToken(F.getE
https://github.com/s-perron ready_for_review
https://github.com/llvm/llvm-project/pull/112757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron converted_to_draft
https://github.com/llvm/llvm-project/pull/112757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/5] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/5] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/4] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/3] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/112757
>From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 16 Oct 2024 13:20:29 -0400
Subject: [PATCH 1/2] [HLSL][SPIRV] Add convergence tokens to entry point
wrappe
@@ -469,14 +480,21 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
for (auto &F : M.functions()) {
if (!F.hasFnAttribute("hlsl.shader"))
continue;
-IRBuilder<> B(&F.getEntryBlock(), F.getEntryBlock().begin());
+auto* Token = getConvergenceToken(F.getE
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ab208de34efbde4fea03732eaa353a701e72f626
24e84865fe8cd9684c6e5b2763970ba278038039 --e
@@ -469,14 +480,21 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
for (auto &F : M.functions()) {
if (!F.hasFnAttribute("hlsl.shader"))
continue;
-IRBuilder<> B(&F.getEntryBlock(), F.getEntryBlock().begin());
+auto* Token = getConvergenceToken(F.getE
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Steven Perron (s-perron)
Changes
Inlining currently assumes that either all function use controled
convergence or none of them do. This is why we need to have the entry
point wrapper use controled convergence.
https://github.com/ll
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Steven Perron (s-perron)
Changes
Inlining currently assumes that either all function use controled
convergence or none of them do. This is why we need to have the entry
point wrapper use controled convergence.
https://github.com/llvm/llvm-
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/112757
Inlining currently assumes that either all function use controled
convergence or none of them do. This is why we need to have the entry
point wrapper use controled convergence.
https://github.com/llvm/llvm-proj
24 matches
Mail list logo
