[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-04-05 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: ping https://github.com/llvm/llvm-project/pull/132869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-04-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: So, the main benefit of this is that is can parallelize the linker jobs? Doing that requires a special flag passed to the linker wrapper. https://github.com/llvm/llvm-project/pull/132869 ___ cfe-commits mailing li

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-28 Thread Yaxun Liu via cfe-commits
@@ -9332,11 +9332,22 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, // Add the linker arguments to be forwarded by the wrapper. CmdArgs.push_back(Args.MakeArgString(Twine("--linker-path=") + LinkCommand->getE

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-28 Thread Joseph Huber via cfe-commits
@@ -9332,11 +9332,22 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, // Add the linker arguments to be forwarded by the wrapper. CmdArgs.push_back(Args.MakeArgString(Twine("--linker-path=") + LinkCommand->getE

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-28 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/132869 >From 205999ed91d9ed65dcfb73377f853ae7e35a7bda Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 21 Mar 2025 14:16:44 -0400 Subject: [PATCH] [HIP] use offload wrapper for non-device-only non-rdc Curr

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/132869 >From a7b74b80018d15a3c2c30bbc363b73e691ece269 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 21 Mar 2025 14:16:44 -0400 Subject: [PATCH] [HIP] use offload wrapper for non-device-only non-rdc Curr

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8244f8210f2e62f68429a0daf104fd483ada45ab 987007b668991ab8027a569f2aaafb5237dfc194 --e

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/132869 >From 987007b668991ab8027a569f2aaafb5237dfc194 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 21 Mar 2025 14:16:44 -0400 Subject: [PATCH] [HIP] use offload wrapper for non-device-only non-rdc Curr

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Yaxun Liu via cfe-commits
@@ -9348,11 +9348,22 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, // Add the linker arguments to be forwarded by the wrapper. CmdArgs.push_back(Args.MakeArgString(Twine("--linker-path=") + LinkCommand->getE

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Joseph Huber via cfe-commits
@@ -9348,11 +9348,22 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, // Add the linker arguments to be forwarded by the wrapper. CmdArgs.push_back(Args.MakeArgString(Twine("--linker-path=") + LinkCommand->getE

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Yaxun Liu via cfe-commits
@@ -9348,11 +9348,22 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, // Add the linker arguments to be forwarded by the wrapper. CmdArgs.push_back(Args.MakeArgString(Twine("--linker-path=") + LinkCommand->getE

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Yaxun Liu via cfe-commits
@@ -4945,12 +4959,15 @@ Action *Driver::BuildOffloadingActions(Compilation &C, } } -// Compiling HIP in non-RDC mode requires linking each action individually. +// Compiling HIP in device-only non-RDC mode requires linking each action +// individually.

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-27 Thread Yaxun Liu via cfe-commits
@@ -4502,6 +4506,16 @@ void Driver::BuildActions(Compilation &C, DerivedArgList &Args, InputArg)) break; + // For HIP non-rdc non-device-only compilation, create a linker wrapper yxs

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Yaxun (Sam) Liu (yxsamliu) Changes Currently HIP still uses offload bundler for non-rdc mode for the new offload driver. This patch switches to use offload wrapper for non-device-only non-rdc mode when new offload driver is enabl

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-24 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/132869 Currently HIP still uses offload bundler for non-rdc mode for the new offload driver. This patch switches to use offload wrapper for non-device-only non-rdc mode when new offload driver is enabled. This make

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Currently HIP still uses offload bundler for non-rdc mode for the new offload driver. This patch switches to use offload wrapper for non-device-only non-rdc mode when new offload driver is enabled. Thi

[clang] [HIP] use offload wrapper for non-device-only non-rdc (PR #132869)

2025-03-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes Currently HIP still uses offload bundler for non-rdc mode for the new offload driver. This patch switches to use offload wrapper for non-device-only non-rdc mode when new offload driver is enable